[Links] Panel Placement#165919
Merged
ThomThomson merged 13 commits intoelastic:navigation-embeddablefrom Sep 11, 2023
Merged
Conversation
…vigation/PanelPlacement
ThomThomson
commented
Sep 11, 2023
| breakpoints={breakpoints} | ||
| onDragStop={onLayoutChange} | ||
| onResizeStop={onLayoutChange} | ||
| onLayoutChange={onLayoutChange} |
Contributor
Author
There was a problem hiding this comment.
This change fixes #165909. I fixed that in this PR because the problem is much more obvious here.
…-ref HEAD~1..HEAD --fix'
nickpeihl
approved these changes
Sep 11, 2023
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! I love the implementation of the panel strategies. code review and tested in several different resolutions.
I would love to see panel strategies used by the CopyPanelAction, but I spoke offline with @ThomThomson about this and that should be accomplished in a different PR.
Comment on lines
+63
to
+68
| latestVersion?: string | undefined; | ||
| telemetry?: | ||
| | ((state: EmbeddableStateWithType, stats: Record<string, any>) => Record<string, any>) | ||
| | undefined; | ||
| migrations?: MigrateFunctionsObject | GetMigrationFunctionObjectFn | undefined; | ||
| grouping?: UiActionsPresentableGrouping<unknown> | undefined; |
| } | ||
|
|
||
| const isHorizontal = attributes.layout === 'horizontal'; | ||
| const width = isHorizontal ? DASHBOARD_GRID_COLUMN_COUNT : 8; |
Contributor
There was a problem hiding this comment.
I tested this at different resolutions (3840x2160, 1920x1080, 1280x720) and 8 seems like a good default width. I can't imagine authors using smaller resolutions. And authors can always resize to support the preferred resolution of viewers. 👍
| try { | ||
| explicitInput = await embeddableFactory.getExplicitInput(undefined, dashboard); | ||
| const explicitInputReturn = await embeddableFactory.getExplicitInput(undefined, dashboard); | ||
| if (isExplicitInputWithAttributes(explicitInputReturn)) { |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #165909
Closes #165400
Closes #165403
This PR adds the ability for Links Panels (and Dashboard panels more broadly) to choose their own size and placement strategy on creation. This PR also fills out the required method on the Navigation Embeddable Factory to place its panels at the top of the Dashboard, and to place them at an appropriate default sizing for their contents.
This behaviour should work the same in the following situations:
Currently, the Horizontal Links panel is by default full width and 4 rows tall and the vertical Links panel is 8 columns wide and the height in rows is calculated as
(number of links * 3) + 4Checklist
Delete any items that are not applicable to this PR.