Skip to content

[7.17] [node] Enable openssl legacy provider#165147

Merged
jbudz merged 1 commit intoelastic:7.17from
jbudz:backport/7.17/163190
Aug 30, 2023
Merged

[7.17] [node] Enable openssl legacy provider#165147
jbudz merged 1 commit intoelastic:7.17from
jbudz:backport/7.17/163190

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Aug 29, 2023

Backports #163190

@jbudz jbudz added the backport This PR is a backport of another PR label Aug 29, 2023
@jbudz jbudz requested review from a team and watson August 29, 2023 20:29
@jbudz jbudz marked this pull request as ready for review August 29, 2023 20:29
Copy link
Copy Markdown
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the upstream version of the PR isn't merged yet, we should wait with this one, so any changes that are made as part of the review process can be included here as well

This is to prevent a breaking change in a minor release of Kibana due to
an underlying upgrade of Node.js to v18.
The legacy provider can be disabled by removing
`--openssl-legacy-provider` in `config/node.options`.

[Node.js
documentation](https://nodejs.org/docs/latest-v18.x/api/cli.html#--openssl-legacy-provider)
[OpenSSL
documentation](https://www.openssl.org/docs/man3.0/man7/OSSL_PROVIDER-legacy.html)

---------

Co-authored-by: Thomas Watson <w@tson.dk>
@jbudz jbudz force-pushed the backport/7.17/163190 branch from c065995 to 4bf0578 Compare August 30, 2023 19:07
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #154642 succeeded ac8eb3333584abf28cbb49c3431a7ec81a7225ca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Aug 30, 2023

4bf0578 pulls in the merged changes.

@jbudz jbudz merged commit 8791f8b into elastic:7.17 Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants