-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing defaults #164957
changing defaults #164957
Conversation
83450ea
to
65c1f99
Compare
65c1f99
to
dfc9e8d
Compare
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine 👍
I've tried to test both locally and in remote CCS and could not see any particular worsening of the performance. Perhaps this could be better measured in a deployed scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem reasonable to me but I'm not super familiar with this code overall. WDYT @lukasolson?
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
resolves #157837
the defaults were updated:
wait_for_completion
is increased to 200ms (from 100ms). this gives es more time to provide initial response before starting the pooling. With this change most responses in our sample dashboards are actually returned in this first response, which improves time to data from 1.2seconds to 0.3seconds in my local teststo test i used shard delay aggregation to simulate slower responses
(add
data.search.aggs.shardDelay.enabled: true
to kibana.dev.yml` and use legacy visualizations and add a chart split with aggregation shard delay before adding anything else to the chart)