[Dashboard Navigation] Store unwrapped attributes in componentState#164887
Merged
nickpeihl merged 1 commit intoelastic:navigation-embeddablefrom Aug 28, 2023
Merged
Conversation
nickpeihl
added
the
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
Heenawter
approved these changes
Aug 28, 2023
Contributor
Heenawter
left a comment
Heenawter
left a comment
There was a problem hiding this comment.
Code review only - very straightforward 👍
Comment on lines
+25
to
+26
| const links = navEmbeddable.select((state) => state.componentState.links); | ||
| const layout = navEmbeddable.select((state) => state.componentState.layout); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164322
Store the unwrapped attributes from by-reference links panels in
componentState.Since the
explictInputfor a Links panel can be either by-reference or by-value, we need to be sure to share the unwrapped attributes (as in from a by-reference panel) to our component.