[8.9] chore(NA): upgrade typescript into v4.7.4 (#162738) by mistic · Pull Request #164761 · elastic/kibana

mistic · 2023-08-24T17:15:44Z

Backport

This will backport the following commits from main to 8.9:

chore(NA): upgrade typescript into v4.7.4 (#162738)

Questions ?

Please refer to the Backport tool documentation

@gergoabraham

This PR bumps the Typescript version used on Kibana into v4.7.4. During the upgrade I got the impression the majority of the failures were too specific to the codebase so instead of making assumptions I choose to marked a lot of them with `@ts-expect-error` and let each team decide how to handle it. Next you can find a list of files with those comments and the teams to who they belong to. I would appreciate the collaboration from each team on fixing those. I'm not opposed on fixing those in subsequent PRs after this one have been merged, just wanted to elaborate that list for a good follow up: @elastic/kibana-core - [x] [packages/core/http/core-http-router-server-internal/src/request.ts](https://github.com/elastic/kibana/pull/162738/files#diff-c1f4a8c013c6ff9c5170803322414cb002f70331b23e45c55f075258c678410a) @elastic/kibana-data-discovery - [x] [src/plugins/discover/public/components/doc_table/components/table_row.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-9106b254a57e73fc6f0b2e01f9aff1abbd26f1a0999e6fa998f1b45d3013038f) @elastic/kibana-visualizations - [x] [src/plugins/expressions/common/execution/execution.ts](https://github.com/elastic/kibana/pull/162738/files#diff-47bf3af7472c08ede90f86575ee7db4b8a2c949b1fb61400410ed16a8d819667) - [x] [src/plugins/expressions/common/expression_functions/expression_function_parameter.ts](https://github.com/elastic/kibana/pull/162738/files#diff-3bcaa3c50f2297ff990c7ac83a1c2d36a79e6706a09082c3c48a911713afe950) - [x] [src/plugins/vis_types/heatmap/public/editor/components/labels_panel.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-345db24d53f4158414480b890fa43d1f8a454b67313de79602fda081279cbc4f) - [x] [src/plugins/vis_types/xy/public/editor/components/options/metrics_axes/label_options.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-1c346b41cf025ff4f4e07b6d6dcdd1451cbaa758f9a9e8c72a9801d3fbbdfda2) @elastic/kibana-presentation - [x] [x-pack/plugins/canvas/public/components/workpad_page/workpad_interactive_page/event_handlers.ts](https://github.com/elastic/kibana/pull/162738/files#diff-56858ed9be77830ab218eab1960337240926609c5a1593b3960b35660ef81359) @elastic/response-ops - [x] [x-pack/plugins/cases/public/components/create/form.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-c5c415f1f56ca986f4bb59e65490b5e0fc77a86092240c0c1a26c141dba07818) - [x] [x-pack/plugins/cases/public/components/markdown_editor/editable_markdown_renderer.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-ab038916f6fed59e18b0a72ce8e823e88d115afdb2704010d0fa8656b66702df) - [x] [x-pack/plugins/rule_registry/server/alert_data_client/browser_fields/index.ts](https://github.com/elastic/kibana/pull/162738/files#diff-3f91aa93f7e6514c0479a37a76d6e9a53646d4eaf5dcd0db64437eadf1eee6b6) - [x] [x-pack/plugins/triggers_actions_ui/.storybook/decorator.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-fbf1d6d0104c11c3f3690d29edf06000b5a63a858bb22b7d04d1f96a45133b07) - [x] [x-pack/plugins/triggers_actions_ui/common/experimental_features.ts](https://github.com/elastic/kibana/pull/162738/files#diff-8e2ca70700895b17125532779945a1d0ab9076b4d4db304c065b47f82b6628a5) - [x] [x-pack/plugins/triggers_actions_ui/public/common/get_experimental_features.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-8e2ca70700895b17125532779945a1d0ab9076b4d4db304c065b47f82b6628a5) @elastic/fleet - [x] [x-pack/plugins/fleet/common/experimental_features.ts](https://github.com/elastic/kibana/pull/162738/files#diff-a852b157b5ff1d6dbf321ea8a25f0020d8f88cd458378cc9de8ef25ce28c9414) - [x] [x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/index.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-9eea0be0f9341dd6369720ce7b11bff69dda51230337ebbae921f6abde187bd2) - [x] [x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-844d5f9707b739d25f2b73bd34c45c21e2e5d573b3238c13130a0d1c1db092dc) - [x] [x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/index.test.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-f88d92abbc549ddc95d693bf3a3bc9752613cf74f1e859a01ca61d572e031b11) - [x] [x-pack/plugins/fleet/server/mocks/index.ts](https://github.com/elastic/kibana/pull/162738/files#diff-d3f3e436b158ac2d877b7be9d57642855f89b0149cc28735811443da45bb079f) @elastic/security-detection-engine - [x] [x-pack/plugins/lists/server/services/extension_points/extension_point_storage_client.ts](https://github.com/elastic/kibana/pull/162738/files#diff-dbbf5a8541e06fd977c66e44d9ef59f738d953bdfda679ac838e098742c92f50) - [x] [x-pack/plugins/lists/server/services/extension_points/types.ts](https://github.com/elastic/kibana/pull/162738/files#diff-31186826bea8fdb286a25878fa06eeacad8f7a6c384d617fed905d4625821eef) @elastic/security-defend-workflows @gergoabraham - [x] [x-pack/plugins/security_solution/public/detection_engine/rule_response_actions/osquery/osquery_response_action.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-049eeedef2a403ade7c636418e17fc9a3ffc7030eec2f3e013f459721c076470) @elastic/infra-monitoring-ui - [x] [x-pack/plugins/monitoring/public/application/pages/apm/overview.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-4ab4fa150247d8f522741ae5ea1ea71c102c72f5439410ea869ec1c9dc9878ad) - [x] [x-pack/plugins/monitoring/public/application/pages/enterprise_search/overview.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-285a67d9ec93651206608d308e5d1d20ccc98ccccb9bcbf3ee31fe35c1844b42) @elastic/kibana-security - [x] [x-pack/plugins/security/server/authentication/authenticator.ts](https://github.com/elastic/kibana/pull/162738/files#diff-bd369002fdfd0986f1ce3bf16263fb8b765e01a86832ccf5b4e521811d502038) - [x] [x-pack/plugins/security/server/session_management/session_index.ts](https://github.com/elastic/kibana/pull/162738/files#diff-10b76eb52a0e17564ad864def8270bb84a4eb87eb35851309bc36601086cbcd7) @elastic/security-threat-hunting-explore @gergoabraham - [x] [x-pack/plugins/security_solution/public/common/mock/endpoint/app_context_render.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-7f130bdc9a954330d188aa25324910cf2f72baf76d1329bd36584f5bb153856b) @elastic/security-solution @gergoabraham - [x] [x-pack/plugins/security_solution/public/management/components/page_overlay/page_overlay.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-e68a2799df17238257a86ce965369c525be901f6f882e518bde9e8c9bd7cd2c8) - [x] [x-pack/plugins/security_solution/public/management/pages/policy/view/policy_settings_form/components/event_collection_card.tsx](https://github.com/elastic/kibana/pull/162738/files#diff-edc756f655792f7dcaca0c707f35c6c022981be1873712f460ccb1d611e42568) - [x] [x-pack/plugins/security_solution/tsconfig.json](https://github.com/elastic/kibana/pull/162738/files#diff-844dde79a96b9e6c2bfdf21f8c80feb8b687577e21326da6bd15c6b95d8ec918) @elastic/uptime - [x] [x-pack/plugins/uptime/server/legacy_uptime/lib/alerts/duration_anomaly.test.ts](https://github.com/elastic/kibana/pull/162738/files#diff-6c7b63ce65aa17a2fe3219e1747ae051be88fb02edbe2f198ad6fd418a2bcc57) @elastic/security-detections-response-alerts @gergoabraham - [x] [x-pack/test/detection_engine_api_integration/security_and_spaces/group8/exception_operators_data_types/keyword_array.ts](https://github.com/elastic/kibana/pull/162738/files#diff-472ba2c7fe43448c8a4d04406703f755f71f6e60146bb2f090b4ca0f19ad0a0f) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michael Dokolin <dokmic@gmail.com> Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> Co-authored-by: Devon Thomson <devon.thomson@elastic.co> (cherry picked from commit 2d652e1) # Conflicts: # packages/core/http/core-http-router-server-internal/src/versioned_router/is_valid_route_version.ts # src/plugins/console/public/lib/autocomplete/autocomplete.ts # x-pack/plugins/index_management/__jest__/client_integration/index_details_page/mocks.ts # x-pack/plugins/security_solution/public/management/pages/policy/view/policy_settings_form/components/event_collection_card.tsx # x-pack/plugins/triggers_actions_ui/.storybook/decorator.tsx # x-pack/plugins/triggers_actions_ui/public/common/get_experimental_features.test.tsx # x-pack/test_serverless/functional/test_suites/security/cypress/tasks/endpoint_management/response_actions.ts # x-pack/test_serverless/shared/lib/security/kibana_roles/role_loader.ts # yarn.lock

…-ref HEAD~1..HEAD --fix'

kibana-ci · 2023-08-25T05:50:18Z

💛 Build succeeded, but was flaky

Failed CI Steps

Security Solution Tests #5

Test Failures

[job] [logs] Security Solution Tests #5 / Hover actions Adds global filter - filter in

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	993.4KB	993.4KB	+9.0B
`discover`	424.7KB	424.8KB	+19.0B
`visTypeXy`	42.2KB	42.2KB	+10.0B
total			+38.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`charts`	45.7KB	45.7KB	+21.0B
`expressions`	98.0KB	98.1KB	+154.0B
total			+175.0B

History

💔 Build #153387 failed a617242
💔 Build #153282 failed 4499e09

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic added the backport This PR is a backport of another PR label Aug 24, 2023

botelastic Bot added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 24, 2023

mistic enabled auto-merge (squash) August 24, 2023 17:15

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

4499e09

…-ref HEAD~1..HEAD --fix'

mistic mentioned this pull request Aug 24, 2023

chore(NA): upgrade typescript into v4.7.4 #162738

Merged

31 tasks

mistic added 2 commits August 25, 2023 04:41

chore(NA): solve types problems

a617242

chore(NA): solve types problems

f3330ac

botelastic Bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 25, 2023

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

007e9c0

…-ref HEAD~1..HEAD --fix'

mistic disabled auto-merge August 25, 2023 12:20

mistic merged commit ebf21b6 into elastic:8.9 Aug 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.9] chore(NA): upgrade typescript into v4.7.4 (#162738)#164761

[8.9] chore(NA): upgrade typescript into v4.7.4 (#162738)#164761
mistic merged 5 commits intoelastic:8.9from
mistic:backport/8.9/pr-162738

mistic commented Aug 24, 2023

Uh oh!

kibana-ci commented Aug 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mistic commented Aug 24, 2023

Backport

Questions ?

Uh oh!

kibana-ci commented Aug 25, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants