Skip to content

[Task Manager] Force validation on all tasks using state#164574

Merged
mikecote merged 10 commits intoelastic:mainfrom
mikecote:task-manager/force-task-state-validation
Sep 26, 2023
Merged

[Task Manager] Force validation on all tasks using state#164574
mikecote merged 10 commits intoelastic:mainfrom
mikecote:task-manager/force-task-state-validation

Conversation

@mikecote
Copy link
Contributor

@mikecote mikecote commented Aug 23, 2023 •
edited
Loading

Resolves #159347
Part of #155764

In this PR, I'm forcing validation on any tasks using state by ensuring a state schema is defined by the task type. Without this schema and once this PR merges, Task Manager will now fail validation by throwing [TaskValidator] stateSchemaByVersion not defined for task type: XYZ errors. This forces an explicit schema to be defined so we can properly handle state objects in ZDT environments.

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.11.0 labels Aug 23, 2023
@mikecote mikecote self-assigned this Aug 23, 2023
@mikecote
Copy link
Contributor Author

mikecote commented Aug 29, 2023

@elasticmachine merge upstream

@mikecote
Copy link
Contributor Author

mikecote commented Sep 12, 2023

@elasticmachine merge upstream

@mikecote
Copy link
Contributor Author

mikecote commented Sep 25, 2023

@elasticmachine merge upstream

@mikecote
Copy link
Contributor Author

mikecote commented Sep 25, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Sep 25, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

@mikecote mikecote marked this pull request as ready for review September 25, 2023 18:20
@mikecote mikecote requested a review from a team as a code owner September 25, 2023 18:20
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 25, 2023

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote merged commit d86eebd into elastic:main Sep 26, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 26, 2023
mikecote added a commit that referenced this pull request Oct 3, 2023
@mikecote
Revert "[Task Manager] Force validation on all tasks using state (#16…
1df0ec8 
…4574)"

This reverts commit d86eebd.
@mikecote mikecote mentioned this pull request Oct 3, 2023
Merged
mikecote added a commit that referenced this pull request Oct 3, 2023
@mikecote @kibanamachine @XavierM
Revert "[Task Manager] Force validation on all tasks using state (#16… (
395f75e 
#167877)

Revert of #164574

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees

@mikecote mikecote

Labels

backport:skip This PR does not require backporting Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task Manager] Force validation on all tasks using state by removing the exemption code

5 participants

@mikecote @kibana-ci @elasticmachine @ymao1 @kibanamachine