Skip to content

better error message for using invalid field in agg #16413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmcconaghy wants to merge 2 commits into from
Closed

better error message for using invalid field in agg #16413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b05d91
using .raw keyword field for aggregation when it exists instead of ju…
bmcconaghy Jan 30, 2018
e95570b
removing field swapping logic and just supplying better error message
bmcconaghy Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui/public/agg_types/param_types/field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export function FieldParamTypeProvider(Private, $filter) {

const validField = this.getFieldOptions(aggConfig).byName[fieldName];
if (!validField) {
notifier.error(`Saved "field" parameter is now invalid. Please select a new field.`);
notifier.error(`Field "${fieldName}" is not aggregatable. Please replace it with a keyword version of the field.`);
}

return validField;
Expand Down