Skip to content

Hide caret when indices has no time fields, remove indices object containing unused string #16412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jen-huang merged 1 commit into from
Jan 30, 2018
Merged

Hide caret when indices has no time fields, remove indices object containing unused string #16412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...ic/management/sections/indices/create_index_pattern_wizard/create_index_pattern_wizard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,7 @@ uiModules.get('apps/management')
const dateFields = fields.filter(field => field.type === 'date');

if (dateFields.length === 0) {
return [{
display: `The indices which match this index pattern don't contain any time fields.`,
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to keep this message, right? I think it's just the caret which is out of place, unless I'm missing something.

Copy link
Copy Markdown
Contributor Author

@jen-huang jen-huang Jan 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string isn't actually being used for the display, the real string is in step_time_field.html so I removed this one as extraneous code.

Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow OK!

}];
return [];
}

return [
Expand Down
1 change: 1 addition & 0 deletions ...agement/sections/indices/create_index_pattern_wizard/step_time_field/step_time_field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ <h2 class="euiTitle euiTitle--small">
</select>

<svg
ng-hide="stepTimeField.canShowNoTimeBasedFieldsMessage()"
class="euiIcon euiFormControlLayout__icon euiFormControlLayout__icon--right euiIcon--medium"
xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink"
Expand Down