Skip to content

[APM][Profiling] Adding feature flag to enable profiling integration#163823

Merged
cauemarcondes merged 3 commits intoelastic:mainfrom
cauemarcondes:profiling-apm-feature-flag
Aug 14, 2023
Merged

[APM][Profiling] Adding feature flag to enable profiling integration#163823
cauemarcondes merged 3 commits intoelastic:mainfrom
cauemarcondes:profiling-apm-feature-flag

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

Screenshot 2023-08-14 at 3 11 13 PM

When Profiling is initiated but feature flag is not enabled:
Screenshot 2023-08-14 at 3 17 14 PM

When Profiling is initiated and feature flag is enabled:
Screenshot 2023-08-14 at 3 18 59 PM

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 14, 2023
@cauemarcondes cauemarcondes requested a review from a team as a code owner August 14, 2023 14:36
@cauemarcondes cauemarcondes requested a review from a team August 14, 2023 14:36
@cauemarcondes cauemarcondes requested a review from a team as a code owner August 14, 2023 14:36
@cauemarcondes cauemarcondes requested a review from a team August 14, 2023 14:36
@botelastic botelastic Bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 14, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:APM)

@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Copy Markdown
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@mdbirnstiehl
Copy link
Copy Markdown
Member

I wonder if we could give the user a little bit more on what they can hope to find from these links. As is, the user would have to click on each link to see exactly what info they provide. After adding flamegraphs, topN functions, and stack traces, we don't mention them in the description text. Might it make sense to give a small descriptor for each link, maybe a tool tip for those that aren't as immediately obvious as logs and metrics?

I could be missing some context, but that's just my first reaction.

@boriskirov
Copy link
Copy Markdown
Contributor

I wonder if we could give the user a little bit more on what they can hope to find from these links. As is, the user would have to click on each link to see exactly what info they provide. After adding flamegraphs, topN functions, and stack traces, we don't mention them in the description text. Might it make sense to give a small descriptor for each link, maybe a tool tip for those that aren't as immediately obvious as logs and metrics?

I could be missing some context, but that's just my first reaction.

@mdbirnstiehl great suggestion, we had a proposed way of improving the selectors across APM because of the scalability issues this example is showing, for now, it will not fall into the current plans

@cauemarcondes cauemarcondes requested a review from a team as a code owner August 14, 2023 15:37
@cauemarcondes
Copy link
Copy Markdown
Contributor Author

@mdbirnstiehl could you approve this PR, please?

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 511 518 +7

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
observability 45 46 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB +129.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 59.2KB 59.4KB +146.0B
Unknown metric groups

API count

id before after diff
observability 518 525 +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 309666a into elastic:main Aug 14, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 14, 2023
@cauemarcondes cauemarcondes deleted the profiling-apm-feature-flag branch August 14, 2023 17:50
bmorelli25 added a commit that referenced this pull request Aug 15, 2023
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Aug 16, 2023
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
…163823)

<img width="1493" alt="Screenshot 2023-08-14 at 3 11 13 PM"
src="https://github.com/elastic/kibana/assets/55978943/6bafa1e3-7075-4779-92ae-35ab30436255">

When Profiling is initiated but feature flag is not enabled:
<img width="381" alt="Screenshot 2023-08-14 at 3 17 14 PM"
src="https://github.com/elastic/kibana/assets/55978943/fb4821b9-2bcc-4a7d-bd77-b200e3d43892">

When Profiling is initiated and feature flag is enabled:
<img width="369" alt="Screenshot 2023-08-14 at 3 18 59 PM"
src="https://github.com/elastic/kibana/assets/55978943/cf8ed7c6-77ee-48e7-bf82-7fc2a7101d6b">
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants