Skip to content

Update usage of deprecated EUI components in SharedUx plugins#163560

Merged
vadimkibana merged 23 commits intoelastic:mainfrom
vadimkibana:eui-deprecations-sharedux
Aug 14, 2023
Merged

Update usage of deprecated EUI components in SharedUx plugins#163560
vadimkibana merged 23 commits intoelastic:mainfrom
vadimkibana:eui-deprecations-sharedux

Conversation

@vadimkibana
Copy link
Copy Markdown
Contributor

@vadimkibana vadimkibana commented Aug 10, 2023 •
edited
Loading

Summary

Partially addresses #161422

@vadimkibana vadimkibana changed the title Eui deprecations sharedux Update usage of deprecated EUI components in SharedUx plugins Aug 10, 2023
@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.10.0 labels Aug 10, 2023
@vadimkibana
Copy link
Copy Markdown
Contributor Author

vadimkibana commented Aug 10, 2023

@elasticmachine merge upstream

@vadimkibana vadimkibana marked this pull request as ready for review August 10, 2023 08:52
@vadimkibana vadimkibana requested review from a team as code owners August 10, 2023 08:52
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 10, 2023

Pinging @elastic/appex-sharedux (Team:SharedUX)

@vadimkibana vadimkibana enabled auto-merge (squash) August 10, 2023 08:52
@vadimkibana vadimkibana mentioned this pull request Aug 10, 2023
Closed
@vadimkibana vadimkibana self-assigned this Aug 10, 2023
@vadimkibana
Copy link
Copy Markdown
Contributor Author

vadimkibana commented Aug 10, 2023

@elasticmachine merge upstream

auto-merge was automatically disabled August 10, 2023 13:42

Head branch was pushed to by a user without write access

@vadimkibana vadimkibana enabled auto-merge (squash) August 10, 2023 14:08
@Dosant
Copy link
Copy Markdown
Contributor

Dosant commented Aug 10, 2023

FTR Configs #29 / reporting examples Captures PNG file matches the baseline image

😅 nice to see the screenshot tests work

auto-merge was automatically disabled August 13, 2023 19:02

Head branch was pushed to by a user without write access

@streamich streamich force-pushed the eui-deprecations-sharedux branch from 984bbe4 to f5d5e2f Compare August 13, 2023 19:02
@vadimkibana
Copy link
Copy Markdown
Contributor Author

vadimkibana commented Aug 13, 2023

@elasticmachine merge upstream

@vadimkibana vadimkibana enabled auto-merge (squash) August 13, 2023 19:03
auto-merge was automatically disabled August 13, 2023 20:44

Head branch was pushed to by a user without write access

@vadimkibana vadimkibana enabled auto-merge (squash) August 13, 2023 20:44
auto-merge was automatically disabled August 14, 2023 08:10

Head branch was pushed to by a user without write access

@vadimkibana vadimkibana enabled auto-merge (squash) August 14, 2023 08:11
auto-merge was automatically disabled August 14, 2023 10:20

Head branch was pushed to by a user without write access

@vadimkibana vadimkibana enabled auto-merge (squash) August 14, 2023 10:20
auto-merge was automatically disabled August 14, 2023 12:01

Head branch was pushed to by a user without write access

@vadimkibana vadimkibana enabled auto-merge (squash) August 14, 2023 12:01
@vadimkibana vadimkibana merged commit cc8e8fe into elastic:main Aug 14, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Aug 14, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 58 72 +14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
share 2.5KB 5.5KB +3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 51.9KB 52.0KB +56.0B
Unknown metric groups

References to deprecated APIs

id before after diff
share 8 3 -5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vadimkibana

@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dosant Dosant Dosant approved these changes

Assignees

@vadimkibana vadimkibana

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vadimkibana @elasticmachine @Dosant @kibana-ci @kibanamachine