Skip to content

[Cloud Security] [Findings] [Vulnerabilities] [Alerts] - Create detection rule#163545

Merged
opauloh merged 17 commits intoelastic:mainfrom
opauloh:alerts/vulnerabilities-rules
Aug 15, 2023
Merged

[Cloud Security] [Findings] [Vulnerabilities] [Alerts] - Create detection rule#163545
opauloh merged 17 commits intoelastic:mainfrom
opauloh:alerts/vulnerabilities-rules

Conversation

@opauloh
Copy link
Copy Markdown
Contributor

@opauloh opauloh commented Aug 9, 2023

Summary

It closes #162112

This PR adds the option to create a detection rule from a Vulnerabilities Flyout using the defaults established here.

it also:

  • moves the vulnerabilities finding an object to the common schema folder
  • moves the reference link logic to a custom function

Screenshot

Take Action Button

image

Success notification

image

Rule page after clicking the View rule button

SIEM Rules - Kibana (2)

@opauloh opauloh requested a review from a team as a code owner August 9, 2023 23:03
@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.10.0 labels Aug 9, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Copy link
Copy Markdown
Contributor

@JordanSh JordanSh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👑, added some comments

missing_fields_strategy: AlertSuppressionMissingFieldsStrategy.Suppress,
},
index: [LATEST_FINDINGS_INDEX_DEFAULT_NS],
index: [FINDINGS_INDEX_PATTERN],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering, why are we not using the latest-findings/vuln?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great question, as we plan to deprecate the transforms, having existing rules using the transformed index would make it harder for us to apply backward compatibility in the future. Our transforms routines run every 5 minutes with a 60 seconds delay, and the rule routine runs every hour, there's a small possibility that during this 4 minutes window where data came right after the transform runs, and the rule routine runs, an alert can be triggered before the finding can be seen in the UI, but that's just a couple of minutes delay and worth not having to deal with Backward compatibility later.

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 220 222 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 255.1KB 257.1KB +2.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 13.1KB 13.3KB +258.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@opauloh opauloh merged commit 3045b16 into elastic:main Aug 15, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 15, 2023
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
…tion rule (#163545)

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cloud Security] [Findings] [Vulnerabilities] [Alerts] - Create detection rule with API

5 participants