Add timeWindow type changes to slo docs#163367
Merged
wandergeek merged 4 commits intomainfrom Aug 11, 2023
Merged
Conversation
wandergeek
added
the
Team:Observability
Contributor
|
Pinging @elastic/unified-observability (Team:Observability) |
wandergeek
added
the
release_note:skip
kdelemme
reviewed
Aug 8, 2023
| ], | ||
| "timeWindow": { | ||
| "duration": "7d", | ||
| "isRolling": true |
Contributor
There was a problem hiding this comment.
fwiw, we are probably going to remove the composite_slo related feature as it is now
kdelemme
reviewed
Aug 8, 2023
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
Just a duration to change but otherwise looks good!
Thanks for making those changes, this file was forgotten
Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
kdelemme
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We're moving away from boolean timeWindow type designation to a more consistent "type" field. This PR fixes up some documentation.
Note: I'm unsure about
1wgoing to7d. Last time I tried, the API didn't like it so I went ahead and changed the docs to reflect that. Unsure if this is expected behavior.