[data views] Disable scripted fields in serverless environment#163228
Merged
mattkime merged 36 commits intoelastic:mainfrom Aug 23, 2023
Merged
[data views] Disable scripted fields in serverless environment#163228mattkime merged 36 commits intoelastic:mainfrom
mattkime merged 36 commits intoelastic:mainfrom
Conversation
mattkime
changed the title
mattkime
added
Feature:Data Views
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
azasypkin
approved these changes
Aug 15, 2023
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
Changes in test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM
drewdaemon
approved these changes
Aug 15, 2023
…ime/kibana into disable_scripted_fields_serverless
jughosta
reviewed
Aug 16, 2023
Contributor
jughosta
left a comment
jughosta
left a comment
There was a problem hiding this comment.
Looking good! There is one more case to consider: disable navigation to "Create scripted field" page. I was able to go there by changing URL to /app/management/kibana/dataViews/dataView/<data-view-id>/create-field/ and it let me to submit the form without errors.
src/plugins/data_view_management/public/components/edit_index_pattern/tabs/utils.ts
Outdated
Show resolved
Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/scripted_fields.ts
Outdated
Show resolved
Hide resolved
| const euiTabs: EuiTabbedContentTab[] = useMemo( | ||
| () => | ||
| getTabs(indexPattern, fieldFilter, relationships.length).map( | ||
| getTabs(indexPattern, fieldFilter, relationships.length, dataViews.scriptedFieldsEnabled).map( |
Contributor
There was a problem hiding this comment.
Would be great to add a functional test for tabs
| ...body.script_fields, | ||
| ...scriptFields, | ||
| }; | ||
| body.script_fields = this.dependencies.scriptedFieldsEnabled |
Contributor
There was a problem hiding this comment.
Would be great to add a unit test for this case too
Contributor
Author
There was a problem hiding this comment.
@lukasolson Do you have any suggestions on how to do this?
…ime/kibana into disable_scripted_fields_serverless
…pted_fields.ts Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>
…ime/kibana into disable_scripted_fields_serverless
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @mattkime |
davismcphee
approved these changes
Aug 23, 2023
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Pulled and tested locally and it works as expected! LGTM, thanks 👍
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 23, 2023
* main: (150 commits) Fixes unnecessary autocompletes on HTTP methods (elastic#163233) [Defend Workflows] Convert filterQuery to kql (elastic#161806) [Fleet] copy `inactivity_timeout` when duplicating agent policy (elastic#164544) Fix 7.17 forward compatibility with 8.2+ (elastic#164274) [ML] Fixes dark mode in flyouts and modals (elastic#164399) [Defend Workflows]Changes to policy settings are not persistent until a refresh (elastic#164403) [Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (elastic#164329) Prepare the Security domain HTTP APIs for Serverless (elastic#162087) skip failing test suite (elastic#160986) [Security Solution] Fix flaky Event Filters test (elastic#164473) [EDR workflows] Osquery serverless tests (elastic#163795) [Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (elastic#164469) [Chrome UI] Fix background color in serverless (elastic#164419) [DOCS] Saved objects - resolve import errors API (elastic#162825) Remove 'Create Rule' button from Rule Group page (elastic#164167) [Security Solution] expandable flyout - fix infinite loop in correlations (elastic#163450) [Remote Clusters] Update copy about port help text (elastic#164442) [api-docs] 2023-08-23 Daily api_docs build (elastic#164524) [data views] Disable scripted fields in serverless environment (elastic#163228) [Reporting] Fix - show diagnostic only when image reporting is enabled (elastic#164336) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables scripted fields in serverless environments. Data view defined scripted fields are ignored and the scripted fields tab in data view management is hidden.
scriptedFieldsEnabled is defined via conditional config that's only available in serverless environments.