[Security Solution] Unskip "use_fetch_or_create_rule_exception_list.test.tsx" tests#163169
Merged
e40pud merged 6 commits intoelastic:mainfrom Aug 8, 2023
Merged
Conversation
e40pud
added
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
vitaliidm
approved these changes
Aug 7, 2023
Contributor
vitaliidm
left a comment
vitaliidm
left a comment
There was a problem hiding this comment.
LGTM, one small comment to consider
...blic/detection_engine/rule_exceptions/logic/use_fetch_or_create_rule_exception_list.test.tsx
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @e40pud |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
…est.tsx" tests (elastic#163169) ## Summary Original ticket: elastic#145749 This PR un-skips tests which were disabled due to [upgrade to Jest 29 here](elastic#143319). Fixes: 1. Restructured test which checks the `isLoading` state returned by the `useFetchOrCreateRuleExceptionList` hook 2. Make sure we call `await waitForNextUpdate();` right amount of times --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Original ticket: #145749
This PR un-skips tests which were disabled due to upgrade to Jest 29 here.
Fixes:
isLoadingstate returned by theuseFetchOrCreateRuleExceptionListhookawait waitForNextUpdate();right amount of times