Upgrade EUI to v86.0.0#163088
Merged
jbudz merged 41 commits intoelastic:mainfrom Aug 14, 2023
1Copenut:eui/v86.0.0
Merged
Conversation
1Copenut
added
release_note:skip
cee-chen
reviewed
Aug 8, 2023
x-pack/plugins/lens/public/visualizations/datatable/components/columns.tsx
Outdated
Show resolved
Hide resolved
…/columns.tsx Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
botelastic
bot
added
Team:APM - DEPRECATED
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
|
sabarasaba
approved these changes
Aug 11, 2023
jcger
approved these changes
Aug 11, 2023
juliaElastic
approved these changes
Aug 11, 2023
ioanatia
approved these changes
Aug 14, 2023
nreese
approved these changes
Aug 14, 2023
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-gis changes LGTM
code review, tested in chrome
vitaliidm
approved these changes
Aug 14, 2023
jbudz
approved these changes
Aug 14, 2023
drewdaemon
reviewed
Aug 14, 2023
Contributor
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Overall looks great. I opened a PR with a few suggestions.
EUI upgrade: visualization team suggestions
drewdaemon
approved these changes
Aug 14, 2023
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @1Copenut |
bryce-b
pushed a commit
that referenced
this pull request
Aug 22, 2023
`85.1.0` ➡️ `86.0.0`⚠️ The biggest change in this PR is migrating the `react-beautiful-dnd` dependency to it's open-source forked successor, `@hello-pangea/dnd`. This new fork has better typescript support and additionally supports both React 17 and React 18. ## [`86.0.0`](https://github.com/elastic/eui/tree/v86.0.0) - Added React 18 support (StrictMode not yet supported). ([#7012](elastic/eui#7012)) **Deprecations** - Deprecated `euiPaletteComplimentary`; Use `euiPaletteComplementary` instead. ([#6992](elastic/eui#6992)) **Breaking changes** - Replaced the underlying drag-and-drop library from `react-beautiful-dnd` to its fork `@hello-pangea/dnd` ([#7012](elastic/eui#7012)) ([#7012](elastic/eui#7012)) - No code updates are needed if using only `<EuiDragDropContext>`, `<EuiDroppable>` and `<EuiDraggable>` with no direct imports from `react-beautiful-dnd`. In case you were importing things from `react-beautiful-dnd` and using them together with EUI components, you need to switch to `@hello-pangea/dnd` which has cross-compatible API. --------- Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co> Co-authored-by: Tomasz Kajtoch <tomek@kajto.ch> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com> Co-authored-by: Drew Tate <andrew.tate@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
85.1.0➡️86.0.0react-beautiful-dnddependency to it's open-source forked successor,@hello-pangea/dnd. This new fork has better typescript support and additionally supports both React 17 and React 18.86.0.0Deprecations
euiPaletteComplimentary; UseeuiPaletteComplementaryinstead. (#6992)Breaking changes
react-beautiful-dndto its fork@hello-pangea/dnd(#7012) (#7012)<EuiDragDropContext>,<EuiDroppable>and<EuiDraggable>with no direct imports fromreact-beautiful-dnd. In case you were importing things fromreact-beautiful-dndand using them together with EUI components, you need to switch to@hello-pangea/dndwhich has cross-compatible API.