[Security Solution][Defend Workflows] Fix type errors indicated by TS 4.7.4.

[gergoabraham]

Summary

TypeScript 4.7.4 shows some errors in our codebase, and the errors are suppressed in PR #162738. This will be merged after the linked PR.

This PR modifies the code so there's no need for suppressing the errors. There were 2 lint errors I couldn't fix.

---

1️⃣
The following one I didn't manage to fix without a deeper refactor (link)

// x-pack/plugins/security_solution/public/common/mock/endpoint/app_context_render.tsx

  const store = createStore(
    mockGlobalState,
    storeReducer,
    kibanaObservable,
    storage,
    // @ts-expect-error ts upgrade v4.7.4
    [...managementMiddlewareFactory(coreStart, depsStart), middlewareSpy.actionSpyMiddleware]
  );

---

2️⃣
Also, I have no idea how to fix this (link):

  pipeRun<
    T extends ExtensionPoint['type'],
    D extends NarrowExtensionPointToType<T> = NarrowExtensionPointToType<T>,
    // @ts-expect-error ts upgrade v4.7.4
    P extends Parameters<D['callback']> = Parameters<D['callback']>
  >(
    extensionType: T,
    initialCallbackInput: P[0]['data'],
    callbackContext: ServerExtensionCallbackContext,
    callbackResponseValidator?: (data: P[0]['data']) => Error | undefined
  ): Promise<P[0]['data']>;

Tried by merging D and P, or by creating a helper type using infer to unwrap the type of data, but anyway I got type errors, so after some hours, I just let this go. Please let me know if you got an idea.

[elasticmachine]

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

[gergoabraham]

@elasticmachine merge upstream

[gergoabraham]

@elasticmachine merge upstream

[tomsonpl]

@gergoabraham I remember we had some issues here (not typescript but how it works). Are you sure this change preserves the behavior?

[gergoabraham]

I am mostly sure, yes...

OsqueryForm comes from useKibana().services.osquery.OsqueryResponseActionTypeForm, which got its value during plugin start, and its value is the return value of getLazyOsqueryResponseActionTypeForm(), which - independently of the lazy load - returns a function component which itself is never falsy, so based on this, I believe there should be no problem.

...but...

I'm happy to test it if you can help what should be tested here. I did some basic tests (i.e. tried to use this component, by throttling network connection so it loads slowly) and there were no issues.

[tomsonpl]

I remember there was some strange behaviour that is why I made this OqueryForm check. I'll test it manually to see if this is not broken now. I am saying this just because there is a strange behavior in the test. It's not succesful - it's pending...

[tomsonpl]

I tested this manually and I think it still works as expected, thanks!
However - can you please do me a favor and remove the browser filter from here? Lets see if this make the test run then. https://github.com/elastic/kibana/blob/4180a1a105053e5579e6852082bdeaa06f019cd3/x-pack/plugins/osquery/cypress/e2e/all/alerts_response_actions_form.cy.ts#L33C16-L33C16

[gergoabraham]

thank you for testing it!

removed the browser filters, let's see what happens: dac76a5

[tomsonpl]

I think something is broken, moreover the artifacts are not build. Feel free to revert this commit and just ship your changes. I'll take care of osquery testing in a separate PR. How does this sound?

[gergoabraham]

revert is done, thanks for the help, @tomsonpl!
cf43db4

[gergoabraham]

@elasticmachine merge upstream

[tomsonpl]

LGTM, thanks for the changes and thanks for bearing with me 👍

[gergoabraham]

@elasticmachine merge upstream

[gergoabraham]

@elasticmachine merge upstream

[gergoabraham]

@elasticmachine merge upstream

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 8be2f2c

Failed CI Steps

• FTR Configs #33
• Investigations - Security Solution Cypress Tests #6

Test Failures

• [job] [logs] FTR Configs #33 / serverless security UI Case View page "before all" hook for "should show the case view page correctly"
• [job] [logs] Investigations - Security Solution Cypress Tests #6 / Timeline search and filters Update kqlMode for timeline should be able to update timeline kqlMode with filter should be able to update timeline kqlMode with filter

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	12.6MB	12.6MB	-393.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
osquery	51.1KB	51.1KB	+35.0B

History

• 💛 Build #159001 was flaky 44daf46
• 💔 Build #158689 failed 6ef6e1a
• 💔 Build #158646 failed fa5836f
• 💔 Build #158606 failed dac76a5
• 💚 Build #157872 succeeded 13cfd99
• 💔 Build #155641 failed 6f76946

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @gergoabraham