[Cloud Security] AWS Organization form#162571
Merged
JordanSh merged 3 commits intoelastic:mainfrom Jul 26, 2023
Merged
Conversation
JordanSh
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
JordanSh
commented
Jul 26, 2023
| // we only wish to call this once on mount | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
| }, [input]); |
Contributor
Author
There was a problem hiding this comment.
We need this because we have so many calls to updatePolicy when this page mount that each one is overriding the others. I think we should open a tech debt to consolidate all of those calls and create some getInitialValues function that will handle all of that logic on its own.
For now this will run on input change but won't pass the if condition unless account type is not set which is only the case on initial mount.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @JordanSh |
opauloh
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #161345
Summary
Screen.Recording.2023-07-26.at.17.47.12.mov
CTA Button should switch toSave & Launch CloudFormationaccording to the to the Figma