[Serverless] #7099 Move install prepackaged timelines schema#162314
[Serverless] #7099 Move install prepackaged timelines schema#162314lgestc merged 5 commits intoelastic:mainfrom
Conversation
| import { unionWithNullType } from '../../../utility_types'; | ||
| import { ImportTimelinesSchemaRt, TimelineSavedToReturnObjectRuntimeType } from '..'; | ||
|
|
||
| export const checkTimelineStatusRt = rt.type({ |
There was a problem hiding this comment.
I wonder if it's better to rename it to checkPrepackagedTimelines or checkImportTimelines or something a little bit more specific.
michaelolo24
left a comment
There was a problem hiding this comment.
Thanks for making this change so quickly!
|
@elasticmachine merge upstream |
banderror
left a comment
There was a problem hiding this comment.
Rule Management changes LGTM, thanks @lgestc 👍
The only change relevant to us was in the x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/get_prebuilt_rules_and_timelines_status/get_prebuilt_rules_and_timelines_status_route.ts file. However, in the GH UI it was showing me 3 files (out of 5 files changed in this PR) that I was supposed to own: Only files owned by you (3). Running node ./code-owners.js 162314 showed this:
## Files by Code Owner
### elastic/security-detection-rule-management
* x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/get_prebuilt_rules_and_timelines_status/get_prebuilt_rules_and_timelines_status_route.ts
### elastic/security-solution
* x-pack/plugins/security_solution/common/api/timeline/index.ts
* x-pack/plugins/security_solution/common/api/timeline/install_prepackaged_timelines/install_prepackaged_timelines.ts
* x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/get_prebuilt_rules_and_timelines_status/get_prebuilt_rules_and_timelines_status_route.ts
* x-pack/plugins/security_solution/server/lib/timeline/routes/prepackaged_timelines/install_prepackaged_timelines/index.ts
* x-pack/plugins/security_solution/server/lib/timeline/utils/check_timelines_status.ts
### elastic/security-threat-hunting-investigations
* x-pack/plugins/security_solution/server/lib/timeline/routes/prepackaged_timelines/install_prepackaged_timelines/index.ts
* x-pack/plugins/security_solution/server/lib/timeline/utils/check_timelines_status.ts
@lgestc @michaelolo24 Can we please update the CODEOWNERS file to assign the Investigations team to the x-pack/plugins/security_solution/common/api/timeline folder? I believe it's not assigned which can generate unnecessary code owner review requests.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @lgestc |
…lastic#162314) ## Summary This PR moves the last remaining timeline api schema to a common location as per elastic/security-team#7099 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…api (#162857) Closes elastic/security-team#7099 Follow up to #162314 I mislabeled 3 timeline-related internal APIs as detection engine APIs on [this spreadsheet](https://docs.google.com/spreadsheets/d/1VCoJ74EkyGuj59VwWj_3v2ecB84pNCpzGqkYnS0SUKw/edit?pli=1#gid=1102015677) (create_tags, get_tags_by_name, get_dashboards_by_tags). The APIs are now correctly categorized on the spreadsheet and this PR establishes schemas for them in `/common/api`. I also converted these 3 small schemas to io-ts to make it easier to avoid pulling in `@kbn/config-schema` to `public`, as that increased the async chunk size by a full 840KB.
…api (elastic#162857) Closes elastic/security-team#7099 Follow up to elastic#162314 I mislabeled 3 timeline-related internal APIs as detection engine APIs on [this spreadsheet](https://docs.google.com/spreadsheets/d/1VCoJ74EkyGuj59VwWj_3v2ecB84pNCpzGqkYnS0SUKw/edit?pli=1#gid=1102015677) (create_tags, get_tags_by_name, get_dashboards_by_tags). The APIs are now correctly categorized on the spreadsheet and this PR establishes schemas for them in `/common/api`. I also converted these 3 small schemas to io-ts to make it easier to avoid pulling in `@kbn/config-schema` to `public`, as that increased the async chunk size by a full 840KB.
Summary
This PR moves the last remaining timeline api schema to a common location as per https://github.com/elastic/security-team/issues/7099
Checklist
Delete any items that are not applicable to this PR.
For maintainers