[Defend workflows] Stop spreading whole request to ES dsl#162116
Merged
tomsonpl merged 2 commits intoelastic:mainfrom Jul 19, 2023
Merged
[Defend workflows] Stop spreading whole request to ES dsl#162116tomsonpl merged 2 commits intoelastic:mainfrom
tomsonpl merged 2 commits intoelastic:mainfrom
Conversation
tomsonpl
added
chore
release_note:skip
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
patrykkopycinski
approved these changes
Jul 18, 2023
gergoabraham
approved these changes
Jul 18, 2023
Contributor
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
looks great! please check my question if you are okay with that, otherwise 🚢 it
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @tomsonpl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solved a part of https://github.com/elastic/security-team/issues/6988 which was firstly implemented in: #161806
After giving it some thoughts we decided not to introduce breaking changes to our API yet.