Add support for Docker and Serverless to kbn/es#161927
Merged
Ikuni17 merged 85 commits intoelastic:mainfrom Jul 26, 2023
Merged
Add support for Docker and Serverless to kbn/es#161927Ikuni17 merged 85 commits intoelastic:mainfrom
Ikuni17 merged 85 commits intoelastic:mainfrom
Conversation
Ikuni17
commented
Jul 22, 2023
jbudz
reviewed
Jul 24, 2023
jbudz
reviewed
Jul 24, 2023
jbudz
reviewed
Jul 24, 2023
jbudz
reviewed
Jul 24, 2023
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @Ikuni17 |
jbudz
reviewed
Jul 26, 2023
|
|
||
| ['discovery.type', 'single-node'], | ||
|
|
||
| ['xpack.security.enabled', 'false'], |
Contributor
There was a problem hiding this comment.
Was this needed for the docker command too? I know we want it for serverless, but it seems like we can run the default version normally.
Contributor
Author
There was a problem hiding this comment.
@jbudz I was having SSL issues running Kibana local dev against Docker ES. ES was denying HTTP request and the socket was hanging. Should we follow up with another ticket for proper SSL support?
jbudz
approved these changes
Jul 26, 2023
6 tasks
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
Closes elastic#159260 ## Summary Adds support for running ES through Docker and Serverless in `@kbn/es` ### Checklist Delete any items that are not applicable to this PR. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #159260
Summary
Adds support for running ES through Docker and Serverless in
@kbn/esChecklist
Delete any items that are not applicable to this PR.