Skip to content

Enable restriction of internal APIs for serverless #161733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pheyos wants to merge 1 commit into from
Closed

Enable restriction of internal APIs for serverless #161733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ data.search.sessions.enabled: false
advanced_settings.enabled: false

# Enforce restring access to internal APIs see https://github.com/elastic/kibana/issues/151940
# server.restrictInternalApis: true
server.restrictInternalApis: true
Comment on lines 50 to +51
Copy link
Contributor

@pgayvallet pgayvallet Jul 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, Tina or JL would need to confirm, but I think doing that in the "production" config file may break a lot of things ATM.

Why not doing it via CLI args in the FTR suites that are supposed to run against serverless, as we do for every other suite and/or setting when we need to override the defaults for a given FTR suite?

More globally, I don't think a test-only feature or change should ever need to touch the config folder.

Copy link
Contributor

@TinaHeiligers TinaHeiligers Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jloleysens I missed this.

Copy link
Contributor

@jloleysens jloleysens Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we are working through this on this PR #162636.

We plan on turning this on here in ~1 week #162149

# Telemetry enabled by default and not disableable via UI
telemetry.optIn: true
telemetry.allowChangingOptInStatus: false
Expand Down
1 change: 1 addition & 0 deletions x-pack/test_serverless/api_integration/services/svl_common_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { FtrProviderContext } from '../ftr_provider_context';

const COMMON_REQUEST_HEADERS = {
'kbn-xsrf': 'some-xsrf-token',
'x-elastic-internal-origin': 'some-value',
};

export function SvlCommonApiServiceProvider({}: FtrProviderContext) {
Expand Down