[Security Solution] Extend Prebuilt rules install and update workflow test coverage #161687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdjere
force-pushed
the
extend-install-update-workflow-test-coverage
branch
2 times, most recently
from
2c7dfa3
to
52e7201
Compare
jpdjere
added
test
Team:Detections and Resp
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
jpdjere
changed the title
jbudz
reviewed
Jul 18, 2023
test.txt
Outdated
| @@ -0,0 +1,36 @@ | |||
| debg KIBANA_CI_STATS_CONFIG environment variable not found, disabling CiStatsReporter | |||
There was a problem hiding this comment.
Thanks, will remove it
|
Running flaky test runner for: #161802 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2671 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jpdjere |
xcrzx
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
I've reviewed the Cypress tests to some degree and I've come up with some suggestions for making them more readable and easier to maintain. Given the time pressure to review and merge the PR by the end of the day, I don't believe we can even partially address these comments right now. So, I'm approving the PR, and we can tackle these comments when Juan returns from his PTO.
I also haven't had time to thoroughly review the integrational tests included in this PR or to check how these tests align with the test plan.
| login(); | ||
| resetRulesTableState(); | ||
| deleteAlertsAndRules(); | ||
| esArchiverResetKibana(); |
There was a problem hiding this comment.
Why do we need esArchiverResetKibana here?
There was a problem hiding this comment.
We don't, removing in #165488
| describe('Detection rules, Prebuilt Rules Installation and Update - Authorization/RBAC', () => { | ||
| beforeEach(() => { | ||
| login(); | ||
| resetRulesTableState(); |
There was a problem hiding this comment.
Why do we need resetRulesTableState here?
There was a problem hiding this comment.
We don't, removing in #165488
| beforeEach(() => { | ||
| login(); | ||
| resetRulesTableState(); | ||
| deleteAlertsAndRules(); |
There was a problem hiding this comment.
Can we delete all existing rules and create new ones only once in before instead of doing that multiple times using beforeEach?
Comment on lines
+29
to
+48
| const OUTDATED_RULE_1 = createRuleAssetSavedObject({ | ||
| name: 'Outdated rule 1', | ||
| rule_id: RULE_1_ID, | ||
| version: 1, | ||
| }); | ||
| const UPDATED_RULE_1 = createRuleAssetSavedObject({ | ||
| name: 'Updated rule 1', | ||
| rule_id: RULE_1_ID, | ||
| version: 2, | ||
| }); | ||
| const OUTDATED_RULE_2 = createRuleAssetSavedObject({ | ||
| name: 'Outdated rule 2', | ||
| rule_id: RULE_2_ID, | ||
| version: 1, | ||
| }); | ||
| const UPDATED_RULE_2 = createRuleAssetSavedObject({ | ||
| name: 'Updated rule 2', | ||
| rule_id: RULE_2_ID, | ||
| version: 2, | ||
| }); |
There was a problem hiding this comment.
Should only one outdated rule suffice for these tests?
| }); | ||
| beforeEach(() => { | ||
| // Now login with read-only user in preparation for test | ||
| createAndInstallMockedPrebuiltRules({ rules: [RULE_1, RULE_2], installToKibana: false }); |
There was a problem hiding this comment.
Understanding the final state of the rules table can be a bit challenging. This is because some rules are set up in the top-level beforeEach, while others are installed in the beforeEach at this level. To grasp the final state, you have to flip back and forth between the two sections and the body of the test. Moreover, it is not clear why outdated rules are required for this particular test case (rule installation). Could we do the precondition setup in one location for clarity?
For this entire suite, we need 1 outdated rule and 1 ready for installation. Let's do this setup once for both test cases in the before section.
There was a problem hiding this comment.
Yes, all the setup for this is being simplified in #165488
Comment on lines
+189
to
+207
| const assertUpgradeSuccessOrFailure = ( | ||
| rules: Array<typeof SAMPLE_PREBUILT_RULE>, | ||
| didRequestFail: boolean | ||
| ) => { | ||
| const rulesString = rules.length > 1 ? 'rules' : 'rule'; | ||
| const toastMessage = didRequestFail | ||
| ? `${rules.length} ${rulesString} failed to update.` | ||
| : `${rules.length} ${rulesString} updated successfully.`; | ||
| cy.get(TOASTER).should('be.visible').should('have.text', toastMessage); | ||
| if (didRequestFail) { | ||
| for (const rule of rules) { | ||
| cy.get(RULES_UPDATES_TABLE).contains(rule['security-rule'].name); | ||
| } | ||
| } else { | ||
| for (const rule of rules) { | ||
| cy.get(rule['security-rule'].name).should('not.exist'); | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
It would be good to avoid using complex logic inside tests. Tests should be as simple as possible to make sure that they are easy to understand and maintain. If there's a lot of logic in our tests, they become like any other code that needs debugging, which can make tracking down test failures more difficult.
I suggest splitting this function into two: assert success and assert failure to use them separately in tests.
There was a problem hiding this comment.
Yes, removing all this complex logic in #165488
| return `[data-test-subj="upgradeSinglePrebuiltRuleButton-${ruleId}"]`; | ||
| }; | ||
|
|
||
| export const NO_RULES_AVAILABLE_FOR_INSTALL_MESSSAGE = |
There was a problem hiding this comment.
Typo:
Suggested change
| export const NO_RULES_AVAILABLE_FOR_INSTALL_MESSSAGE = | |
| export const NO_RULES_AVAILABLE_FOR_INSTALL_MESSAGE = |
There was a problem hiding this comment.
Thanks, fixing in #165488
|
|
||
| export const NO_RULES_AVAILABLE_FOR_INSTALL_MESSSAGE = | ||
| '[data-test-subj="noPrebuiltRulesAvailableForInstall"]'; | ||
| export const NO_RULES_AVAILABLE_FOR_UPGRADE_MESSSAGE = |
There was a problem hiding this comment.
Typo:
Suggested change
| export const NO_RULES_AVAILABLE_FOR_UPGRADE_MESSSAGE = | |
| export const NO_RULES_AVAILABLE_FOR_UPGRADE_MESSAGE = |
There was a problem hiding this comment.
Thanks, fixing in #165488
| interceptInstallationRequestToFail(rules, didRequestFail); | ||
| const rule = rules[0]; | ||
| cy.get(getInstallSingleRuleButtonByRuleId(rule['security-rule'].rule_id)).click(); | ||
| cy.wait('@installPrebuiltRules'); |
There was a problem hiding this comment.
In e2e tests, it might be better to rely on user-visible indicators of request progress, such as spinners. This approach, instead of depending on the completion of HTTP requests, can make our tests closer to real-life scenarios and highlight problems with loading states which we have from time to time.
There was a problem hiding this comment.
Makes sense, fixing in #165488
| }); | ||
|
|
||
| describe('Rules installation notification when no rules have been installed', () => { | ||
| beforeEach(() => { |
There was a problem hiding this comment.
Similar to previous comments, here we have three levels of beforeEach blocks making it very hard to understand the initial conditions of the test cases. My recommendation would be to restructure these tests for clarity.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 19, 2023
… test coverage (elastic#161687) ## Summary - Implement test plan as described in `x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md` ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 887b3bd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jpdjere
added a commit
to jpdjere/kibana
that referenced
this pull request
Jul 19, 2023
… test coverage (elastic#161687) ## Summary - Implement test plan as described in `x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md` ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 887b3bd)
Ruhshan
pushed a commit
to Ruhshan/kibana
that referenced
this pull request
Jul 19, 2023
… test coverage (elastic#161687) ## Summary - Implement test plan as described in `x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md` ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
jpdjere
added a commit
that referenced
this pull request
Jul 20, 2023
…rkflow test coverage (#161687) (#162268) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution] Extend Prebuilt rules install and update workflow test coverage (#161687)](#161687) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-19T15:53:15Z","message":"[Security Solution] Extend Prebuilt rules install and update workflow test coverage (#161687)\n\n## Summary\r\n\r\n- Implement test plan as described in\r\n`x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md`\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"887b3bde0598037256ae0bfc0e1eb56a4cd72fbe","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.9.0","v8.10.0"],"number":161687,"url":"https://github.com/elastic/kibana/pull/161687","mergeCommit":{"message":"[Security Solution] Extend Prebuilt rules install and update workflow test coverage (#161687)\n\n## Summary\r\n\r\n- Implement test plan as described in\r\n`x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md`\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"887b3bde0598037256ae0bfc0e1eb56a4cd72fbe"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161687","number":161687,"mergeCommit":{"message":"[Security Solution] Extend Prebuilt rules install and update workflow test coverage (#161687)\n\n## Summary\r\n\r\n- Implement test plan as described in\r\n`x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md`\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"887b3bde0598037256ae0bfc0e1eb56a4cd72fbe"}}]}] BACKPORT-->
6 tasks
|
This PR didn't make it into the latest BC of 8.9.0. Updating the labels. |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
… test coverage (elastic#161687) ## Summary - Implement test plan as described in `x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md` ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
jpdjere
added a commit
that referenced
this pull request
Oct 17, 2023
… refactor (#165488) Fixes: #148192 (Tick the two open checkboxes in that issue when merging this PR) ## Summary This PR rewrites/refactors Cypress tests for the Installation and Upgrade of Prebuilt Rules implemented in #161687. Most of the changes here address feedback received in that PR - answered those comments there. - RBAC/Authorization: adds tests scenarios for users with full privileges (happy path) - Gets rid of huge util helpers such as `assertRuleAvailableForInstallAndInstallOne` and rewrites test cases in a more descriptive way, with step by step actions. - Gets rid of complex logic in tests and their helpers - removing if/else logic within them and removing optional flags passed to helpers. - Fixes `bulkCreateRuleAssets` util and uses it in other helpers to install multiple `security-rule` assets with a single bulk request to ES. Additionally: checked `installation_and_upgrade.md` test plan to make sure it matches with the test in place. Added [link](#166215) to a ticket for a to-do task for the sections: - Rule installation workflow: filtering, sorting, pagination - Rule upgrade workflow: filtering, sorting, pagination ## Flaky test runner ~~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3420~~ ~~🟢~~ https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3513 --------- Co-authored-by: kibanamachine <[email protected]>
jpdjere
added a commit
to jpdjere/kibana
that referenced
this pull request
Oct 17, 2023
… refactor (elastic#165488) Fixes: elastic#148192 (Tick the two open checkboxes in that issue when merging this PR) ## Summary This PR rewrites/refactors Cypress tests for the Installation and Upgrade of Prebuilt Rules implemented in elastic#161687. Most of the changes here address feedback received in that PR - answered those comments there. - RBAC/Authorization: adds tests scenarios for users with full privileges (happy path) - Gets rid of huge util helpers such as `assertRuleAvailableForInstallAndInstallOne` and rewrites test cases in a more descriptive way, with step by step actions. - Gets rid of complex logic in tests and their helpers - removing if/else logic within them and removing optional flags passed to helpers. - Fixes `bulkCreateRuleAssets` util and uses it in other helpers to install multiple `security-rule` assets with a single bulk request to ES. Additionally: checked `installation_and_upgrade.md` test plan to make sure it matches with the test in place. Added [link](elastic#166215) to a ticket for a to-do task for the sections: - Rule installation workflow: filtering, sorting, pagination - Rule upgrade workflow: filtering, sorting, pagination ## Flaky test runner ~~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3420~~ ~~🟢~~ https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3513 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 24c008b) # Conflicts: # x-pack/test/security_solution_cypress/package.json
jpdjere
added a commit
that referenced
this pull request
Oct 17, 2023
…ntation refactor (#165488) (#169129) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Install/Update Prebuilt Rules Test Implementation refactor (#165488)](#165488) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-17T11:05:49Z","message":"[Security Solution] Install/Update Prebuilt Rules Test Implementation refactor (#165488)\n\nFixes: https://github.com/elastic/kibana/issues/148192\r\n\r\n(Tick the two open checkboxes in that issue when merging this PR)\r\n\r\n## Summary\r\n\r\nThis PR rewrites/refactors Cypress tests for the Installation and\r\nUpgrade of Prebuilt Rules implemented in\r\nhttps://github.com//pull/161687. Most of the changes here\r\naddress feedback received in that PR - answered those comments there.\r\n\r\n- RBAC/Authorization: adds tests scenarios for users with full\r\nprivileges (happy path)\r\n- Gets rid of huge util helpers such as\r\n`assertRuleAvailableForInstallAndInstallOne` and rewrites test cases in\r\na more descriptive way, with step by step actions.\r\n- Gets rid of complex logic in tests and their helpers - removing\r\nif/else logic within them and removing optional flags passed to helpers.\r\n- Fixes `bulkCreateRuleAssets` util and uses it in other helpers to\r\ninstall multiple `security-rule` assets with a single bulk request to\r\nES.\r\n\r\nAdditionally: checked `installation_and_upgrade.md` test plan to make\r\nsure it matches with the test in place. Added\r\n[link](#166215) to a ticket for\r\na to-do task for the sections:\r\n- Rule installation workflow: filtering, sorting, pagination\r\n- Rule upgrade workflow: filtering, sorting, pagination\r\n\r\n## Flaky test runner\r\n\r\n\r\n~~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3420~~\r\n~~🟢~~\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3513\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"24c008b4c5026dd543f1b4aded94f3787bce5fb0","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["refactoring","release_note:skip","test-coverage","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.11.0","v8.12.0"],"number":165488,"url":"https://github.com/elastic/kibana/pull/165488","mergeCommit":{"message":"[Security Solution] Install/Update Prebuilt Rules Test Implementation refactor (#165488)\n\nFixes: https://github.com/elastic/kibana/issues/148192\r\n\r\n(Tick the two open checkboxes in that issue when merging this PR)\r\n\r\n## Summary\r\n\r\nThis PR rewrites/refactors Cypress tests for the Installation and\r\nUpgrade of Prebuilt Rules implemented in\r\nhttps://github.com//pull/161687. Most of the changes here\r\naddress feedback received in that PR - answered those comments there.\r\n\r\n- RBAC/Authorization: adds tests scenarios for users with full\r\nprivileges (happy path)\r\n- Gets rid of huge util helpers such as\r\n`assertRuleAvailableForInstallAndInstallOne` and rewrites test cases in\r\na more descriptive way, with step by step actions.\r\n- Gets rid of complex logic in tests and their helpers - removing\r\nif/else logic within them and removing optional flags passed to helpers.\r\n- Fixes `bulkCreateRuleAssets` util and uses it in other helpers to\r\ninstall multiple `security-rule` assets with a single bulk request to\r\nES.\r\n\r\nAdditionally: checked `installation_and_upgrade.md` test plan to make\r\nsure it matches with the test in place. Added\r\n[link](#166215) to a ticket for\r\na to-do task for the sections:\r\n- Rule installation workflow: filtering, sorting, pagination\r\n- Rule upgrade workflow: filtering, sorting, pagination\r\n\r\n## Flaky test runner\r\n\r\n\r\n~~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3420~~\r\n~~🟢~~\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3513\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"24c008b4c5026dd543f1b4aded94f3787bce5fb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165488","number":165488,"mergeCommit":{"message":"[Security Solution] Install/Update Prebuilt Rules Test Implementation refactor (#165488)\n\nFixes: https://github.com/elastic/kibana/issues/148192\r\n\r\n(Tick the two open checkboxes in that issue when merging this PR)\r\n\r\n## Summary\r\n\r\nThis PR rewrites/refactors Cypress tests for the Installation and\r\nUpgrade of Prebuilt Rules implemented in\r\nhttps://github.com//pull/161687. Most of the changes here\r\naddress feedback received in that PR - answered those comments there.\r\n\r\n- RBAC/Authorization: adds tests scenarios for users with full\r\nprivileges (happy path)\r\n- Gets rid of huge util helpers such as\r\n`assertRuleAvailableForInstallAndInstallOne` and rewrites test cases in\r\na more descriptive way, with step by step actions.\r\n- Gets rid of complex logic in tests and their helpers - removing\r\nif/else logic within them and removing optional flags passed to helpers.\r\n- Fixes `bulkCreateRuleAssets` util and uses it in other helpers to\r\ninstall multiple `security-rule` assets with a single bulk request to\r\nES.\r\n\r\nAdditionally: checked `installation_and_upgrade.md` test plan to make\r\nsure it matches with the test in place. Added\r\n[link](#166215) to a ticket for\r\na to-do task for the sections:\r\n- Rule installation workflow: filtering, sorting, pagination\r\n- Rule upgrade workflow: filtering, sorting, pagination\r\n\r\n## Flaky test runner\r\n\r\n\r\n~~https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3420~~\r\n~~🟢~~\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3513\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"24c008b4c5026dd543f1b4aded94f3787bce5fb0"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.mdFor maintainers