Migrate deprecated components in Logstash pipelines section.#161512
Merged
rshen91 merged 2 commits intoelastic:mainfrom Sep 27, 2023
Merged
Migrate deprecated components in Logstash pipelines section.#161512rshen91 merged 2 commits intoelastic:mainfrom
rshen91 merged 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
roaksoax
approved these changes
Sep 20, 2023
roaksoax
left a comment
There was a problem hiding this comment.
lgtm! but not sure the Logstash team review is necessary since we dont really own this code.
Contributor
|
@elasticmachine merge upstream |
Contributor
|
We are looking to finishing the |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mashhurs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the deprecated components in Logstash pipelines view based on the gude.
A list of deprecated components in Logstash pipelines can be found here.
Tests
Opened a dev tools and proceeded manual tests on local dev env (based on local env setup guide):
create pipeline(s)
check list of pipeline(s)
delete pipeline(s)
check alerts when deleting the pipeline
check Elasticsearch .logstash_pipelines index (
GET _logstash/pipeline) to check the data shape which Logstash polls and uses.Closes: [Logstash] Migrate all usages of
EuiPage*_Deprecated#161417Checklist
Delete any items that are not applicable to this PR.
- [ ] Documentation was added for features that require explanation or tutorials- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listRisk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers