Skip to content

Migrate deprecated components in Logstash pipelines section.#161512

Merged
rshen91 merged 2 commits intoelastic:mainfrom
mashhurs:remove-deprecated-euipage-logstash-components
Sep 27, 2023
Merged

Migrate deprecated components in Logstash pipelines section.#161512
rshen91 merged 2 commits intoelastic:mainfrom
mashhurs:remove-deprecated-euipage-logstash-components

Conversation

@mashhurs
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs commented Jul 8, 2023

Summary

Migrates the deprecated components in Logstash pipelines view based on the gude.
A list of deprecated components in Logstash pipelines can be found here.

Tests

Opened a dev tools and proceeded manual tests on local dev env (based on local env setup guide):

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@mashhurs mashhurs self-assigned this Jul 8, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jul 8, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mashhurs mashhurs marked this pull request as ready for review August 1, 2023 17:32
@mashhurs mashhurs requested a review from a team as a code owner August 1, 2023 17:32
Copy link
Copy Markdown

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! but not sure the Logstash team review is necessary since we dont really own this code.

@vadimkibana
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@vadimkibana
Copy link
Copy Markdown
Contributor

We are looking to finishing the EUIPage*_Deprecated work, can this PR be merged?

@vadimkibana vadimkibana added release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Sep 26, 2023
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logstash 31.1KB 31.1KB -30.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mashhurs

@rshen91 rshen91 merged commit fb13b21 into elastic:main Sep 27, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Logstash] Migrate all usages of EuiPage*_Deprecated

6 participants