-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17][Ops] Update babel to 7.21 #161080
[7.17][Ops] Update babel to 7.21 #161080
Conversation
411f884
to
52e02e8
Compare
…nd generator talk about the same types
@elasticmachine merge upstream |
merge conflict between base and head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments about matching deps with main
"@babel/eslint-parser": "^7.16.3", | ||
"@babel/eslint-plugin": "^7.14.5", | ||
"@babel/generator": "^7.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have we removed @babel/generator into a prod dependency? I dont think it is one. In addition to that consider update to version ^7.21.1 to match main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It got a warning from one of the tasks I ran, maybe the storybook - but now I moved it back
I stole all the target versions from main with a script - so they should all be in sync now, the build still doesn't work out |
933f0e7
to
2ff08f7
Compare
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Superceded by #161278 |
Summary
Updates babel to 7.21+, as it's on other open branches.
Closes #160010
Checklist
Delete any items that are not applicable to this PR.