[Infrastructure UI] Add strict payload validation to metrics_explorer_views endpoint#160982
Merged
crespocarlos merged 26 commits intoelastic:mainfrom Jul 14, 2023
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…xplorer-view-strict-input-validation
467841c to
c31ada9
Compare
c31ada9 to
8a63158
Compare
…xplorer-view-strict-input-validation
a5cac8e to
ad47d14
Compare
ad47d14 to
8617361
Compare
Contributor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
neptunian
reviewed
Jul 11, 2023
neptunian
reviewed
Jul 11, 2023
x-pack/plugins/infra/server/saved_objects/metrics_explorer_view/types.ts
Outdated
Show resolved
Hide resolved
neptunian
reviewed
Jul 11, 2023
x-pack/plugins/infra/server/saved_objects/metrics_explorer_view/types.ts
Outdated
Show resolved
Hide resolved
neptunian
reviewed
Jul 12, 2023
| metricsExplorerViewId: rt.string, | ||
| }); | ||
|
|
||
| export type GetMetricsExplorerViewResposePayload = rt.TypeOf<typeof metricsExplorerViewRT>; |
Contributor
There was a problem hiding this comment.
Suggested change
| export type GetMetricsExplorerViewResposePayload = rt.TypeOf<typeof metricsExplorerViewRT>; | |
| export type GetMetricsExplorerViewResposePayload = rt.TypeOf<typeof metricsExplorerViewRT>; |
typo missing 'n' in GetMetricsExplorerViewResponsePayload
neptunian
reviewed
Jul 12, 2023
| createMetricsExplorerViewRequestPayloadRT, | ||
| FindMetricsExplorerViewResponsePayload, | ||
| findMetricsExplorerViewResponsePayloadRT, | ||
| GetMetricsExplorerViewResposePayload, |
Contributor
There was a problem hiding this comment.
Suggested change
| GetMetricsExplorerViewResposePayload, | |
| GetMetricsExplorerViewResponsePayload, |
Contributor
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
neptunian
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #157520
Summary
This PR adds strict payload validation to
metrics_explorer_viewsendpoint. This PR depends on this to be merged #160852How to test
Infrastructure > Metrics Explorer