[8.9] [Alerting] Fix the charts on Log Threshold Rule Alert Detail page (#160321)#160661
Merged
kibanamachine merged 1 commit into8.9from Jun 27, 2023
Merged
[8.9] [Alerting] Fix the charts on Log Threshold Rule Alert Detail page (#160321)#160661kibanamachine merged 1 commit into8.9from
kibanamachine merged 1 commit into8.9from
Conversation
…60321) ## Summary This PR fixes #160320 by changing the chart from the `CriterionPreview` chart, borrowed from the Log Threshold Rule, to an embedded Lens visualization that represents the correct document count in one chart. I also took the liberty of changing the ratio chart to use the same technique for consistency sake. ## Count with multiple conditions ### Before <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/6c6a27ea-f8e4-491f-8a12-261d0ed13dcb"> ### After <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/9b18ebe9-e911-4e40-8911-bee55cd7d245"> ## Count with multiple conditions and a group by ### Before <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/7b9462da-55b2-4f54-ba09-3c55b372ae2c"> ### After <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/b268caed-242f-430a-ade0-14bf491ec899"> ## Ratio with multiple conditions ### Before <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/55b8dfa2-7789-433b-bffd-e412bdb08b3f"> ### After <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/a029bf8a-3ba1-4e16-87bd-097ebc526a4e"> ## Ratio with multiple conditions and a group by ### Before <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/61ddf1e9-c5ad-4546-a539-15a51ee563c0"> ### After <img width="736" alt="image" src="https://github.com/elastic/kibana/assets/41702/15b0aaa3-4ef9-47f6-baba-24869feae77e"> (cherry picked from commit a8322d2)
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.9:Questions ?
Please refer to the Backport tool documentation