Skip to content

Conversation

@lgestc
Copy link
Contributor

@lgestc lgestc commented Jun 27, 2023

Summary

This tiny PR ensures that widget contents are not rendered until expanded (in the expandable flyout). This will
prevent unnecessary requests being sent when we open the flyout.

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Feature:Expandable Flyout Expandable flyout used in the security solution labels Jun 27, 2023
@lgestc lgestc requested review from a team as code owners June 27, 2023 13:46
@lgestc lgestc added v8.10.0 and removed v9.0.0 labels Jun 27, 2023
@lgestc
Copy link
Contributor Author

lgestc commented Jun 28, 2023

@elasticmachine merge upstream

@lgestc
Copy link
Contributor Author

lgestc commented Jun 30, 2023

@elasticmachine merge upstream

Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this comment is more applicable here :)

@lgestc lgestc force-pushed the conditional_rendering_in_expandable_section branch from 52ad499 to 6f5d5cd Compare July 3, 2023 12:40
@elastic elastic deleted a comment from kibanamachine Jul 5, 2023
@elastic elastic deleted a comment from kibanamachine Jul 5, 2023
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4240 4241 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.0MB 11.0MB +462.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc merged commit 901b9eb into main Jul 5, 2023
@lgestc lgestc deleted the conditional_rendering_in_expandable_section branch July 5, 2023 13:20
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Expandable Flyout Expandable flyout used in the security solution release_note:skip Skip the PR/issue when compiling release notes v8.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants