[APM] Add query to check for overflow bucket in service groups#159990
Conversation
|
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
b496a32 to
6b7eb60
Compare
|
Could we add tests to this? |
@yngrdyn I gave that part a thought. Unfortunately we still don't have Synthtrace working with overflow buckets to generate that data. |
yngrdyn
left a comment
There was a problem hiding this comment.
LGTM, it'd be awesome to be able to test features related to this topic (if there are more in the future)
x-pack/plugins/apm/server/lib/service_group_query_with_overflow.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/service_group_query_with_overflow.ts
Outdated
Show resolved
Hide resolved
@yngrdyn Added now 👍🏼 |
|
@dgieselaar @sqren If this gets merged, should this be backported to 8.9 |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
@gbamparop Should this be backported to 8.9 ? |
|
I think since we're past FF we should merge it in and have it ready for 8.10 cc @akhileshpok |
|
Tested locally on current main as edge-oblt and lite are not having overflow scenarios 👍🏼 |
Summary
Closes #157479
This PR adds a check in Service Groups to display overflow bucket if Service metrics have been overflow