Skip to content

[APM] Add query to check for overflow bucket in service groups#159990

Merged
achyutjhunjhunwala merged 16 commits intoelastic:mainfrom
achyutjhunjhunwala:handle_overflow_bucket_for_service_groups
Jun 26, 2023
Merged

[APM] Add query to check for overflow bucket in service groups#159990
achyutjhunjhunwala merged 16 commits intoelastic:mainfrom
achyutjhunjhunwala:handle_overflow_bucket_for_service_groups

Conversation

@achyutjhunjhunwala
Copy link
Copy Markdown
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Jun 20, 2023

Summary

Closes #157479

This PR adds a check in Service Groups to display overflow bucket if Service metrics have been overflow

image

@achyutjhunjhunwala achyutjhunjhunwala added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:feature Makes this part of the condensed release notes labels Jun 20, 2023
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team June 20, 2023 10:16
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Jun 20, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:APM)

@ghost
Copy link
Copy Markdown

ghost commented Jun 20, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@achyutjhunjhunwala achyutjhunjhunwala force-pushed the handle_overflow_bucket_for_service_groups branch from b496a32 to 6b7eb60 Compare June 20, 2023 10:30
@yngrdyn
Copy link
Copy Markdown
Contributor

yngrdyn commented Jun 20, 2023

Could we add tests to this?

@achyutjhunjhunwala
Copy link
Copy Markdown
Contributor Author

Could we add tests to this?

@yngrdyn I gave that part a thought. Unfortunately we still don't have Synthtrace working with overflow buckets to generate that data.

Copy link
Copy Markdown
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it'd be awesome to be able to test features related to this topic (if there are more in the future)

@achyutjhunjhunwala
Copy link
Copy Markdown
Contributor Author

achyutjhunjhunwala commented Jun 22, 2023

LGTM, it'd be awesome to be able to test features related to this topic (if there are more in the future)

@yngrdyn Added now 👍🏼

@achyutjhunjhunwala
Copy link
Copy Markdown
Contributor Author

@dgieselaar @sqren If this gets merged, should this be backported to 8.9

@achyutjhunjhunwala
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #24 / endpoint When on the Endpoint Policy Details Page and the save button is clicked should persist update on the screen

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@achyutjhunjhunwala
Copy link
Copy Markdown
Contributor Author

@gbamparop Should this be backported to 8.9 ?

@gbamparop
Copy link
Copy Markdown
Contributor

I think since we're past FF we should merge it in and have it ready for 8.10 cc @akhileshpok

@achyutjhunjhunwala achyutjhunjhunwala merged commit 05e97f7 into elastic:main Jun 26, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the handle_overflow_bucket_for_service_groups branch June 26, 2023 17:41
@kibanamachine kibanamachine added v8.10.0 backport:skip This PR does not require backporting labels Jun 26, 2023
@achyutjhunjhunwala
Copy link
Copy Markdown
Contributor Author

achyutjhunjhunwala commented Aug 24, 2023

Tested locally on current main as edge-oblt and lite are not having overflow scenarios 👍🏼

@achyutjhunjhunwala achyutjhunjhunwala added the apm:test-plan-done Pull request that was successfully tested during the test plan label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:test-plan-done Pull request that was successfully tested during the test plan backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] UI improvements where service or transaction metrics limits are exceeded

8 participants