Fix hover Action showing for zero Count on D&R Dashboard#158902
Merged
machadoum merged 1 commit intoelastic:mainfrom Jun 2, 2023
Merged
Fix hover Action showing for zero Count on D&R Dashboard#158902machadoum merged 1 commit intoelastic:mainfrom
machadoum merged 1 commit intoelastic:mainfrom
Conversation
machadoum
added
Team:Threat Hunting
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @machadoum |
angorayc
approved these changes
Jun 2, 2023
Contributor
angorayc
left a comment
angorayc
left a comment
There was a problem hiding this comment.
Tested locally, LGTM! Thank you Pablo 👍
machadoum
added
v8.8.1
and removed
backport:skip
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Jun 2, 2023
) issue: elastic#158057 ## Summary Remove hover actions from the table when the count of alerts is zero. **BEFORE**  **AFTER**  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a4889b4)
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Jun 6, 2023
) issue: elastic#158057 ## Summary Remove hover actions from the table when the count of alerts is zero. **BEFORE**  **AFTER**  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a4889b4)
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
machadoum
added a commit
that referenced
this pull request
Jun 7, 2023
…) (#159108) # Backport This will backport the following commits from `main` to `8.8`: - [Fix hover Action showing for zero Count on D&R Dashboard (#158902)](#158902) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-06-02T11:42:15Z","message":"Fix hover Action showing for zero Count on D&R Dashboard (#158902)\n\nissue: https://github.com/elastic/kibana/issues/158057\r\n## Summary\r\n\r\nRemove hover actions from the table when the count of alerts is zero.\r\n\r\n**BEFORE**\r\n\r\n\r\n\r\n\r\n**AFTER**\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a4889b48517ea79974a2eca584f0c7273a6f032a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.9.0","v8.8.2"],"number":158902,"url":"https://github.com/elastic/kibana/pull/158902","mergeCommit":{"message":"Fix hover Action showing for zero Count on D&R Dashboard (#158902)\n\nissue: https://github.com/elastic/kibana/issues/158057\r\n## Summary\r\n\r\nRemove hover actions from the table when the count of alerts is zero.\r\n\r\n**BEFORE**\r\n\r\n\r\n\r\n\r\n**AFTER**\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a4889b48517ea79974a2eca584f0c7273a6f032a"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158902","number":158902,"mergeCommit":{"message":"Fix hover Action showing for zero Count on D&R Dashboard (#158902)\n\nissue: https://github.com/elastic/kibana/issues/158057\r\n## Summary\r\n\r\nRemove hover actions from the table when the count of alerts is zero.\r\n\r\n**BEFORE**\r\n\r\n\r\n\r\n\r\n**AFTER**\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a4889b48517ea79974a2eca584f0c7273a6f032a"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
This PR backport didn't make it into the latest BC for 8.8.1. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #158057
Summary
Remove hover actions from the table when the count of alerts is zero.
BEFORE
AFTER
Checklist