Skip to content

Upgrade EUI to v81.2.0#158781

Merged
cee-chen merged 9 commits intoelastic:mainfrom
cee-chen:eui-v81.2.x
Jun 5, 2023
Merged

Upgrade EUI to v81.2.0#158781
cee-chen merged 9 commits intoelastic:mainfrom
cee-chen:eui-v81.2.x

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented May 31, 2023

Summary

eui@81.0.0eui@81.2.0

  • Most changes to source code in this PR are CSS cleanups/deprecations in EuiSuperDatePicker/EuiDatePickerRange
  • One team (ML) had a inline specific usage of EuiDatePickerRange that they reached out to us about via Slack, and that we have fixed in this PR.
  • All other usages of date picker components should have remained working as-is with no changes, but please ping us if you see otherwise!

81.2.0

  • Updated EuiSuperDatePicker to accept an object configuration for isDisabled (#6821)

Bug fixes

  • Fixed broken EuiSuperDatePicker styles (#6821)

81.1.0

  • Added EuiInlineEditText and EuiInlineEditTitle components (#6757)
  • Updated EuiDatePickerRange to support inline display (#6795)
  • Added an onError callback prop to EuiErrorBoundary (#6810)
  • Updated EuiDataGrid to only render screen reader text announcing cell position if the cell is currently focused. This should improve the ability to copy and paste multiple cells without SR text. (#6817)

Bug fixes

  • Fixed EuiDatePicker's inline display to correctly render and prevent user interaction when disabled or readOnly (#6795)
  • Fixed EuiDatePicker's inline display to correctly render isInvalid and isLoading icons (#6795)

CSS-in-JS conversions

  • Converted EuiDatePickerRange to Emotion (#6795)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.9.0 labels May 31, 2023
@cee-chen cee-chen marked this pull request as ready for review June 1, 2023 00:46
@cee-chen cee-chen requested review from a team as code owners June 1, 2023 00:46
@cee-chen cee-chen requested review from gergoabraham and pzl June 1, 2023 00:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-defend-workflows related modifications look good to me 👍

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Canvas time_filter LGTM 👍

Jun-01-2023 13-41-04

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Threat Hunting Investigations team

@cee-chen
Copy link
Contributor Author

cee-chen commented Jun 5, 2023

@elasticmachine merge upstream

@cee-chen
Copy link
Contributor Author

cee-chen commented Jun 5, 2023

👋 @elastic/uptime One last ping for a CODEOWNER review! I'll be asking KibanaOps to admin merge this PR by EOD today.

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / aiops change point detection shows multiple results when split field is selected

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +22.0B
canvas 993.9KB 993.5KB -463.0B
cloudSecurityPosture 218.8KB 218.9KB +22.0B
dashboard 356.0KB 356.0KB +22.0B
dataViewManagement 118.6KB 118.7KB +22.0B
enterpriseSearch 2.4MB 2.4MB +22.0B
exploratoryView 217.0KB 216.9KB -63.0B
expressionGauge 18.7KB 18.7KB +22.0B
expressionHeatmap 53.8KB 53.8KB +22.0B
expressionPartitionVis 31.1KB 31.1KB +22.0B
expressionXY 120.6KB 120.6KB +22.0B
filesManagement 87.7KB 87.7KB +22.0B
graph 456.3KB 456.4KB +22.0B
home 159.7KB 159.7KB +22.0B
infra 2.0MB 2.0MB +308.0B
kibanaOverview 43.3KB 43.3KB +22.0B
lens 1.2MB 1.2MB +22.0B
management 34.1KB 34.1KB +22.0B
maps 2.7MB 2.7MB +44.0B
ml 3.4MB 3.4MB +60.0B
observabilityShared 35.9KB 35.9KB +22.0B
security 566.5KB 566.5KB +22.0B
securitySolution 10.7MB 10.7MB -375.0B
spaces 174.8KB 174.9KB +22.0B
textBasedLanguages 68.6KB 68.6KB +22.0B
unifiedHistogram 43.4KB 43.4KB +22.0B
unifiedSearch 212.0KB 212.0KB +22.0B
visTypeVega 1.7MB 1.7MB +22.0B
visualizations 260.1KB 260.1KB +22.0B
total +17.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 366.3KB 366.9KB +646.0B
discover 27.5KB 27.5KB +22.0B
esUiShared 154.8KB 154.8KB +22.0B
kbnUiSharedDeps-css 313.2KB 312.5KB -767.0B
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +18.8KB
serverlessSecurity 48.2KB 48.3KB +22.0B
total +18.7KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

@cee-chen
Copy link
Contributor Author

cee-chen commented Jun 5, 2023

Thanks all! 🎉

@cee-chen cee-chen merged commit c52ff7f into elastic:main Jun 5, 2023
@cee-chen cee-chen deleted the eui-v81.2.x branch June 5, 2023 20:51
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.