Skip to content

[RCS 2.0] Bypasses query for field list when configuring FLS against a remote cluster#158728

Merged
jeramysoucy merged 1 commit intoelastic:mainfrom
jeramysoucy:rcs-bypass-field-query
Jun 2, 2023
Merged

[RCS 2.0] Bypasses query for field list when configuring FLS against a remote cluster#158728
jeramysoucy merged 1 commit intoelastic:mainfrom
jeramysoucy:rcs-bypass-field-query

Conversation

@jeramysoucy
Copy link
Copy Markdown
Contributor

@jeramysoucy jeramysoucy commented May 31, 2023

Closes #158280

Summary

This PR implements an index type (local vs remote) check within the index privilege form in order to bypass querying the field list from the index API client for remote cluster indices.

Testing

  • Augmented functional tests in index_privilege_form.test.tsx with 'does not query availble fields for remote cluster indices' test case.

@jeramysoucy jeramysoucy added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// Feature:CCR and Remote Clusters v8.9.0 release_note:skip Skip the PR/issue when compiling release notes release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels May 31, 2023
@jeramysoucy jeramysoucy changed the title [RCS 2.0:] Bypasses query for field list when configuring FLS against a remote cluster [RCS 2.0] Bypasses query for field list when configuring FLS against a remote cluster May 31, 2023
@jeramysoucy jeramysoucy added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels May 31, 2023
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 31, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 566.5KB 566.5KB +41.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 500 504 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jeramysoucy jeramysoucy marked this pull request as ready for review May 31, 2023 15:04
@jeramysoucy jeramysoucy requested a review from a team as a code owner May 31, 2023 15:04
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 31, 2023

Pinging @elastic/kibana-security (Team:Security)

@jeramysoucy jeramysoucy requested a review from thomheymann May 31, 2023 15:04
thomheymann
thomheymann approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, LGTM!

@jeramysoucy jeramysoucy merged commit 8019197 into elastic:main Jun 2, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomheymann thomheymann thomheymann approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RCS 2.0: Don't query for field list when configuring FLS against a remote cluster

5 participants

@jeramysoucy @kibana-ci @elasticmachine @thomheymann @kibanamachine