Skip to content

[Logs+] Replace Monitoring usages of link-to routes#158367

Merged
mohamedhamed-ahmed merged 5 commits intoelastic:mainfrom
mohamedhamed-ahmed:157985-replace-monitoring-link-to-routes-with-the-appropriate-locator
May 25, 2023
Merged

[Logs+] Replace Monitoring usages of link-to routes#158367
mohamedhamed-ahmed merged 5 commits intoelastic:mainfrom
mohamedhamed-ahmed:157985-replace-monitoring-link-to-routes-with-the-appropriate-locator

Conversation

@mohamedhamed-ahmed
Copy link
Copy Markdown
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented May 24, 2023

part of #157985

📝 Summary

After implementing infra locators to allow navigation to the logs UI we need to replace all usages of the old link-to routes so that we have strongly typed navigation to the logs UI.

This PR focuses on replacing link-to usages in the Monitoring plugin.

✅ Testing

  1. Navigate to Stack Monitoring
  2. Choose any of the clusters from the list
  3. Click logs under Elasticsearch
  4. Scroll to the Recent Log Entries section
  5. click on the Logs link Visit Logs to dive deeper.
Screen.Recording.2023-05-24.at.17.54.37.mov

@mohamedhamed-ahmed mohamedhamed-ahmed added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.9.0 labels May 24, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review May 24, 2023 17:19
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner May 24, 2023 17:19
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 456 467 +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 459.4KB 461.1KB +1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 24.1KB 24.1KB +44.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants