Skip to content

[APM UI] Replace logs link-to routes with appropriate locator#158365

Merged
mohamedhamed-ahmed merged 5 commits intoelastic:mainfrom
mohamedhamed-ahmed:157985-replace-apm-link-to-routes-with-the-appropriate-locator
May 30, 2023
Merged

[APM UI] Replace logs link-to routes with appropriate locator#158365
mohamedhamed-ahmed merged 5 commits intoelastic:mainfrom
mohamedhamed-ahmed:157985-replace-apm-link-to-routes-with-the-appropriate-locator

Conversation

@mohamedhamed-ahmed
Copy link
Copy Markdown
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented May 24, 2023

part of #157985

📝 Summary

After implementing infra locators to allow navigation to the logs UI we need to replace all usages of the old link-to routes so that we have strongly typed navigation to the logs UI.

This PR focuses on replacing link-to usages in the APM plugin.

✅ Testing

  1. Navigate to APM -> Services
  2. Follow video below to navigate to where the logs links are located
  3. Links should behave as before and maintain navigation params
Screen.Recording.2023-05-24.at.20.52.39.mov

@mohamedhamed-ahmed mohamedhamed-ahmed added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.9.0 labels May 24, 2023
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +25.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 402 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 482 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review May 24, 2023 19:56
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team May 24, 2023 19:56
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants