[ML] Versioning file upload APIs#158265
Conversation
jgowdyelastic
added
release_note:enhancement
non-issue
|
Pinging @elastic/ml-ui (:ml) |
| ) | ||
| .auth(IMPORTER_USER_NAME, IMPORT_USER_PASSWORD) | ||
| .set('kbn-xsrf', 'kibana') | ||
| .set('version', '1') |
There was a problem hiding this comment.
Use ELASTIC_HTTP_VERSION_HEADER from import { ELASTIC_HTTP_VERSION_HEADER } from '@kbn/core-http-common'; instead of version.
http.fetch converts version to ELASTIC_HTTP_VERSION_HEADER but this does not occur in integration tests.
There was a problem hiding this comment.
Good spot, thanks. This is correct in our previous versioning PRs, but I missed it here.
Updated in 957bbca
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
Use ELASTIC_HTTP_VERSION_HEADER from import { ELASTIC_HTTP_VERSION_HEADER } from '@kbn/core-http-common'; instead of version in integration tests
…c/kibana into versioning-file-upload-apis
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
peteharverson
added
release_note:skip
7 participants
Adds versioning to all of the file upload APIs.
Versions are added to the server side routes and to the client side functions which call the routes.
Updates API tests to add the API version to the request headers.
All of the APIs are internal and have been given the version '1'.
Also renames
/internal/file_data_visualizer/analyze_fileto/internal/file_upload/analyze_fileIt appears this was a mistake from when the route was moved from the data visualiser plugin midway through development on this PR.
Internal APIs
/internal/file_upload/analyze_file/internal/file_upload/has_import_permission/internal/file_upload/index_exists/internal/file_upload/time_field_range