Skip to content

[Logs UI] Decouple log view HTTP API schema from saved object schema#158098

Merged
neptunian merged 1 commit intoelastic:mainfrom
neptunian:152278-separate-so-attribs-type
May 23, 2023
Merged

[Logs UI] Decouple log view HTTP API schema from saved object schema#158098
neptunian merged 1 commit intoelastic:mainfrom
neptunian:152278-separate-so-attribs-type

Conversation

@neptunian
Copy link
Copy Markdown
Contributor

@neptunian neptunian commented May 18, 2023 •
edited
Loading

Resolves #152278.

Separates out the type for saved object infrastructure-monitoring-log-view so the HTTP API no longer references the same type.

@ghost
Copy link
Copy Markdown

ghost commented May 18, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 18, 2023

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian added the release_note:skip Skip the PR/issue when compiling release notes label May 18, 2023
@neptunian neptunian marked this pull request as ready for review May 18, 2023 19:25
@neptunian neptunian requested a review from a team as a code owner May 18, 2023 19:25
tonyghiani
tonyghiani approved these changes May 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@neptunian neptunian merged commit 8e0123e into elastic:main May 23, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This PR does not require backporting labels May 23, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@neptunian @delanni
[Logs UI] Decouple log view HTTP API schema from saved object schema (e…
d35ff0a 
…lastic#158098)

Resolves elastic#152278.

Separates out the type for saved object
`infrastructure-monitoring-log-view` so the HTTP API no longer
references the same type.
@tonyghiani tonyghiani mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Logs UI] Decouple log view HTTP API schema from saved object schema

4 participants

@neptunian @kibana-ci @tonyghiani @kibanamachine