[ML] Fix the file upload telemetry #157888
Merged
darnautov merged 1 commit intoelastic:mainfrom May 17, 2023
Merged
Conversation
darnautov
added
Feature:File Upload
telemetry
darnautov
added
the
release_note:skip
peteharverson
approved these changes
May 16, 2023
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested as described and LGTM
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @darnautov |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 17, 2023
## Summary Fixes the usage collector for the file upload plugin. According to the git history it hasn't been working since elastic#60418. The saved objects repository required for retrieving telemetry data wasn't provided, causing telemetry to fall back to `index_creation_count: 0` after each check. ### How to test Execute the following request in the Dev Console. ``` POST kbn:/api/telemetry/v2/clusters/_stats { "unencrypted": true } ``` [`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36) shouldn't be `null`. (cherry picked from commit 57af98f)
kibanamachine
added a commit
that referenced
this pull request
May 17, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[ML] Fix the file upload telemetry (#157888)](#157888) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T09:36:58Z","message":"[ML] Fix the file upload telemetry (#157888)\n\n## Summary\r\n\r\nFixes the usage collector for the file upload plugin. According to the\r\ngit history it hasn't been working since\r\nhttps://github.com//pull/60418.\r\n\r\nThe saved objects repository required for retrieving telemetry data\r\nwasn't provided, causing telemetry to fall back to\r\n`index_creation_count: 0` after each check.\r\n\r\n\r\n### How to test \r\n\r\nExecute the following request in the Dev Console.\r\n\r\n```\r\nPOST kbn:/api/telemetry/v2/clusters/_stats\r\n{ \"unencrypted\": true }\r\n```\r\n\r\n\r\n[`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36)\r\nshouldn't be `null`.","sha":"57af98f38a535432f7f085abaa3c9e7e4f67a53a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:File Upload","telemetry","v8.9.0","v8.8.1"],"number":157888,"url":"https://github.com/elastic/kibana/pull/157888","mergeCommit":{"message":"[ML] Fix the file upload telemetry (#157888)\n\n## Summary\r\n\r\nFixes the usage collector for the file upload plugin. According to the\r\ngit history it hasn't been working since\r\nhttps://github.com//pull/60418.\r\n\r\nThe saved objects repository required for retrieving telemetry data\r\nwasn't provided, causing telemetry to fall back to\r\n`index_creation_count: 0` after each check.\r\n\r\n\r\n### How to test \r\n\r\nExecute the following request in the Dev Console.\r\n\r\n```\r\nPOST kbn:/api/telemetry/v2/clusters/_stats\r\n{ \"unencrypted\": true }\r\n```\r\n\r\n\r\n[`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36)\r\nshouldn't be `null`.","sha":"57af98f38a535432f7f085abaa3c9e7e4f67a53a"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157888","number":157888,"mergeCommit":{"message":"[ML] Fix the file upload telemetry (#157888)\n\n## Summary\r\n\r\nFixes the usage collector for the file upload plugin. According to the\r\ngit history it hasn't been working since\r\nhttps://github.com//pull/60418.\r\n\r\nThe saved objects repository required for retrieving telemetry data\r\nwasn't provided, causing telemetry to fall back to\r\n`index_creation_count: 0` after each check.\r\n\r\n\r\n### How to test \r\n\r\nExecute the following request in the Dev Console.\r\n\r\n```\r\nPOST kbn:/api/telemetry/v2/clusters/_stats\r\n{ \"unencrypted\": true }\r\n```\r\n\r\n\r\n[`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36)\r\nshouldn't be `null`.","sha":"57af98f38a535432f7f085abaa3c9e7e4f67a53a"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
## Summary Fixes the usage collector for the file upload plugin. According to the git history it hasn't been working since #60418. The saved objects repository required for retrieving telemetry data wasn't provided, causing telemetry to fall back to `index_creation_count: 0` after each check. ### How to test Execute the following request in the Dev Console. ``` POST kbn:/api/telemetry/v2/clusters/_stats { "unencrypted": true } ``` [`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36) shouldn't be `null`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the usage collector for the file upload plugin. According to the git history it hasn't been working since #60418.
The saved objects repository required for retrieving telemetry data wasn't provided, causing telemetry to fall back to
index_creation_count: 0after each check.How to test
Execute the following request in the Dev Console.
mlUsageshouldn't benull.