Skip to content

[8.8] [Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893) #157006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
May 8, 2023
Merged

[8.8] [Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893) #157006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/kbn-cell-actions/src/components/cell_action_item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,24 @@ export const ActionItem = ({
action,
actionContext,
showTooltip,
onClick,
}: {
action: CellAction;
actionContext: CellActionExecutionContext;
showTooltip: boolean;
onClick?: () => void;
}) => {
const actionProps = useMemo(
() => ({
iconType: action.getIconType(actionContext) as IconType,
onClick: () => action.execute(actionContext),
onClick: () => {
action.execute(actionContext);
if (onClick) onClick();
},
'data-test-subj': `actionItem-${action.id}`,
'aria-label': action.getDisplayName(actionContext),
}),
[action, actionContext]
[action, actionContext, onClick]
);

if (!actionProps.iconType) return null;
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-cell-actions/src/components/hover_actions_popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export const HoverActionsPopover: React.FC<Props> = ({
action={action}
actionContext={actionContext}
showTooltip={showActionTooltips}
onClick={closePopover}
/>
))}
{extraActions.length > 0 && (
Expand Down
262 changes: 262 additions & 0 deletions x-pack/plugins/security_solution/cypress/e2e/dashboards/detection_response.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,262 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { getNewRule } from '../../objects/rule';
import { ALERTS_COUNT } from '../../screens/alerts';
import {
CONTROL_FRAMES,
OPTION_LIST_LABELS,
OPTION_LIST_VALUES,
} from '../../screens/common/filter_group';

import {
HOST_TABLE_HOST_NAME_BTN,
HOST_TABLE_ROW_SEV,
HOST_TABLE_ROW_TOTAL_ALERTS,
RULE_TABLE_ROW_RULE_NAME_BTN,
RULE_TABLE_ROW_TOTAL_ALERTS,
RULE_TABLE_VIEW_ALL_OPEN_ALERTS_BTN,
USER_TABLE_ROW_SEV,
USER_TABLE_ROW_TOTAL_ALERTS,
USER_TABLE_USER_NAME_BTN,
} from '../../screens/detection_response';
import { DETECTION_RESPONSE } from '../../screens/security_header';
import { QUERY_TAB_BUTTON, TIMELINE_DATA_PROVIDERS_CONTAINER } from '../../screens/timeline';
import { waitForAlerts } from '../../tasks/alerts';
import { createRule } from '../../tasks/api_calls/rules';
import { cleanKibana } from '../../tasks/common';
import { investigateDashboardItemInTimeline } from '../../tasks/dashboards/common';
import { waitToNavigateAwayFrom } from '../../tasks/kibana_navigation';
import { login, visit } from '../../tasks/login';
import { navigateFromHeaderTo } from '../../tasks/security_header';
import { closeTimeline } from '../../tasks/timeline';
import { ALERTS_URL, DASHBOARDS_URL, DETECTIONS_RESPONSE_URL } from '../../urls/navigation';

describe('Detection response view', () => {
before(() => {
cleanKibana();
login();
createRule(getNewRule());
visit(DETECTIONS_RESPONSE_URL);
});
context('Open in timeline', { testIsolation: false }, () => {
afterEach(() => {
closeTimeline();
});

it(`opens timeline with correct query count for hosts by alert severity table`, () => {
cy.get(HOST_TABLE_ROW_TOTAL_ALERTS)
.first()
.then((sub) => {
const alertCount = sub.text();
cy.get(HOST_TABLE_HOST_NAME_BTN)
.first()
.then((hostNameEl) => {
const hostName = hostNameEl.text();
investigateDashboardItemInTimeline(HOST_TABLE_ROW_TOTAL_ALERTS);
cy.get(QUERY_TAB_BUTTON).should('be.visible').should('contain.text', alertCount);
cy.get(TIMELINE_DATA_PROVIDERS_CONTAINER)
.should('be.visible')
.should(
'contain.text',
`host.name: "${hostName}"ANDkibana.alert.workflow_status: "open"`
);
});
});
});
it(`opens timeline with correct query count for users by alert severity table`, () => {
cy.get(USER_TABLE_ROW_TOTAL_ALERTS)
.first()
.then((sub) => {
const alertCount = sub.text();
cy.get(USER_TABLE_USER_NAME_BTN)
.first()
.then((userNameEl) => {
const userName = userNameEl.text();
investigateDashboardItemInTimeline(USER_TABLE_ROW_TOTAL_ALERTS);
cy.get(QUERY_TAB_BUTTON).should('contain.text', alertCount);
cy.get(TIMELINE_DATA_PROVIDERS_CONTAINER)
.should('be.visible')
.should(
'contain.text',
`user.name: "${userName}"ANDkibana.alert.workflow_status: "open"`
);
});
});
});
it(`opens timeline with correct query count for open alerts by rule table`, () => {
cy.get(RULE_TABLE_ROW_TOTAL_ALERTS)
.first()
.then((sub) => {
const alertCount = sub.text();
cy.get(RULE_TABLE_ROW_RULE_NAME_BTN)
.first()
.then((ruleNameEl) => {
const ruleName = ruleNameEl.text();
investigateDashboardItemInTimeline(RULE_TABLE_ROW_TOTAL_ALERTS);
cy.get(QUERY_TAB_BUTTON).should('contain.text', alertCount);
cy.get(TIMELINE_DATA_PROVIDERS_CONTAINER)
.should('be.visible')
.should(
'contain.text',
`kibana.alert.rule.name: "${ruleName}"ANDkibana.alert.workflow_status: "open"`
);
});
});
});
});

context('Redirection to AlertPage', { testIsolation: false }, () => {
afterEach(() => {
navigateFromHeaderTo(DETECTION_RESPONSE);
});

it('should redirect to alert page with host and status as the filters', () => {
cy.get(HOST_TABLE_ROW_TOTAL_ALERTS)
.first()
.should('be.visible')
.then((sub) => {
const alertCount = sub.text();
cy.get(HOST_TABLE_HOST_NAME_BTN)
.first()
.should('be.visible')
.then((hostNameEl) => {
const hostName = hostNameEl.text();
sub.trigger('click');
waitToNavigateAwayFrom(DASHBOARDS_URL);
cy.url().should((urlString) => {
const url = new URL(urlString);
expect(url.pathname.endsWith(ALERTS_URL)).eq(true);
});
waitForAlerts();
cy.get(ALERTS_COUNT).should('be.visible').should('have.text', `${alertCount} alerts`);
cy.get(CONTROL_FRAMES).should('have.length', 2);
cy.get(OPTION_LIST_LABELS).eq(0).should('have.text', `Status`);
cy.get(OPTION_LIST_VALUES(0)).should('have.text', 'open1');
cy.get(OPTION_LIST_LABELS).eq(1).should('have.text', `Host name`);
cy.get(OPTION_LIST_VALUES(1)).should('have.text', `${hostName}1`);
});
});
});

it('should redirect to alert page with host, status and severity as the filters', () => {
const severityVal = 'high';
cy.get(HOST_TABLE_ROW_SEV(severityVal))
.first()
.should('be.visible')
.then((sub) => {
const alertCount = sub.text();
cy.get(HOST_TABLE_HOST_NAME_BTN)
.first()
.should('be.visible')
.then((hostNameEl) => {
cy.get(HOST_TABLE_ROW_SEV(severityVal)).first().trigger('click');
waitToNavigateAwayFrom(DASHBOARDS_URL);
const hostName = hostNameEl.text();
waitForAlerts();
cy.get(ALERTS_COUNT).should('be.visible').should('have.text', `${alertCount} alerts`);
cy.get(CONTROL_FRAMES).should('have.length', 3);
cy.get(OPTION_LIST_LABELS).eq(0).should('have.text', `Status`);
cy.get(OPTION_LIST_VALUES(0)).should('have.text', 'open1');
cy.get(OPTION_LIST_LABELS).eq(1).should('have.text', 'Host name');
cy.get(OPTION_LIST_VALUES(1)).should('have.text', `${hostName}1`);
cy.get(OPTION_LIST_LABELS).eq(2).should('have.text', 'Severity');
cy.get(OPTION_LIST_VALUES(2)).should('have.text', `${severityVal}1`);
});
});
});
it('should redirect to alert page with user and status as the filters', () => {
cy.get(USER_TABLE_ROW_TOTAL_ALERTS)
.first()
.should('be.visible')
.then((sub) => {
const alertCount = sub.text();
cy.get(USER_TABLE_USER_NAME_BTN)
.first()
.should('be.visible')
.then((userNameEl) => {
const userName = userNameEl.text();
sub.trigger('click');
waitToNavigateAwayFrom(DASHBOARDS_URL);
cy.url().should((urlString) => {
const url = new URL(urlString);
expect(url.pathname.endsWith(ALERTS_URL)).eq(true);
});
waitForAlerts();
cy.get(ALERTS_COUNT).should('be.visible').should('have.text', `${alertCount} alerts`);
cy.get(CONTROL_FRAMES).should('have.length', 2);
cy.get(OPTION_LIST_LABELS).eq(0).should('have.text', `Status`);
cy.get(OPTION_LIST_VALUES(0)).should('have.text', 'open1');
cy.get(OPTION_LIST_LABELS).eq(1).should('have.text', `Username`);
cy.get(OPTION_LIST_VALUES(1)).should('have.text', `${userName}1`);
});
});
});

it('should redirect to alert page with user, status and severity as the filters', () => {
const severityVal = 'high';
cy.get(USER_TABLE_ROW_SEV(severityVal))
.first()
.should('be.visible')
.then((sub) => {
const alertCount = sub.text();
cy.get(USER_TABLE_USER_NAME_BTN)
.first()
.should('be.visible')
.then((userNameEl) => {
const userName = userNameEl.text();
cy.get(USER_TABLE_ROW_SEV(severityVal)).trigger('click');
waitToNavigateAwayFrom(DASHBOARDS_URL);
waitForAlerts();
cy.get(ALERTS_COUNT).should('be.visible').should('have.text', `${alertCount} alerts`);
cy.get(CONTROL_FRAMES).should('have.length', 3);
cy.get(OPTION_LIST_LABELS).eq(0).should('have.text', `Status`);
cy.get(OPTION_LIST_VALUES(0)).should('have.text', 'open1');
cy.get(OPTION_LIST_LABELS).eq(1).should('have.text', 'Username');
cy.get(OPTION_LIST_VALUES(1)).should('have.text', `${userName}1`);
cy.get(OPTION_LIST_LABELS).eq(2).should('have.text', 'Severity');
cy.get(OPTION_LIST_VALUES(2)).should('have.text', `${severityVal}1`);
});
});
});
it('should redirect to alert page with rule name & status as filters', () => {
cy.get(RULE_TABLE_ROW_TOTAL_ALERTS)
.first()
.should('be.visible')
.then((sub) => {
const alertCount = sub.text();
cy.get(RULE_TABLE_ROW_RULE_NAME_BTN)
.first()
.should('be.visible')
.then((ruleNameEl) => {
sub.trigger('click');
waitToNavigateAwayFrom(DASHBOARDS_URL);
const ruleName = ruleNameEl.text();
waitForAlerts();
cy.get(ALERTS_COUNT).should('be.visible').should('have.text', `${alertCount} alerts`);
cy.get(CONTROL_FRAMES).should('have.length', 2);
cy.get(OPTION_LIST_LABELS).eq(0).should('have.text', `Status`);
cy.get(OPTION_LIST_VALUES(0)).should('have.text', 'open1');
cy.get(OPTION_LIST_LABELS).eq(1).should('have.text', 'Rule name');
cy.get(OPTION_LIST_VALUES(1)).should('have.text', `${ruleName}1`);
});
});
});
it('should redirect to "View Open Alerts" correctly', () => {
cy.get(RULE_TABLE_VIEW_ALL_OPEN_ALERTS_BTN)
.first()
.should('be.visible')
.then((sub) => {
sub.trigger('click');
waitToNavigateAwayFrom(DASHBOARDS_URL);
waitForAlerts();
cy.get(CONTROL_FRAMES).should('have.length', 1);
cy.get(OPTION_LIST_LABELS).eq(0).should('have.text', `Status`);
cy.get(OPTION_LIST_VALUES(0)).should('have.text', 'open1');
});
});
});
});
49 changes: 0 additions & 49 deletions ...ck/plugins/security_solution/cypress/e2e/detection_response/open_alerts_in_timeline.cy.ts
View file
Open in desktop

This file was deleted.

12 changes: 12 additions & 0 deletions x-pack/plugins/security_solution/cypress/screens/dashboards/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

import { getDataTestSubjectSelector } from '../../helpers/common';

export const DASHBOARD_INVESTIGATE_IN_TIMELINE_CELL_ACTION = getDataTestSubjectSelector(
'actionItem-security-alertsCount-cellActions-investigateInNewTimeline'
);
26 changes: 26 additions & 0 deletions x-pack/plugins/security_solution/cypress/screens/detection_response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,37 @@
* 2.0.
*/

import { getDataTestSubjectSelector } from '../helpers/common';

export const HOST_TABLE_ROW_TOTAL_ALERTS =
'[data-test-subj="hostSeverityAlertsTable-totalAlerts"] button';

export const HOST_TABLE_HOST_NAME_BTN = getDataTestSubjectSelector('host-details-button');

export const HOST_TABLE_ROW_SEV = (sev: string) => `
${getDataTestSubjectSelector(
`hostSeverityAlertsTable-${sev.toLowerCase()}`
)} ${getDataTestSubjectSelector(`cellActions-renderContent-host.name`)}
`;

export const USER_TABLE_ROW_TOTAL_ALERTS =
'[data-test-subj="userSeverityAlertsTable-totalAlerts"] button';

export const USER_TABLE_USER_NAME_BTN = getDataTestSubjectSelector('users-link-anchor');

export const USER_TABLE_ROW_SEV = (sev: string) => `
${getDataTestSubjectSelector(
`userSeverityAlertsTable-${sev.toLowerCase()}`
)} ${getDataTestSubjectSelector(`cellActions-renderContent-user.name`)}
`;

export const RULE_TABLE_ROW_TOTAL_ALERTS =
'[data-test-subj="severityRuleAlertsTable-alertCount"] button';

export const RULE_TABLE_VIEW_ALL_OPEN_ALERTS_BTN = getDataTestSubjectSelector(
'severityRuleAlertsButton'
);

export const RULE_TABLE_ROW_RULE_NAME_BTN = getDataTestSubjectSelector(
'severityRuleAlertsTable-name'
);
Loading