Skip to content

Comments

[Security Solution][Fix] Alert data doesn't update when updating alert status via alert flyout.#156988

Merged
logeekal merged 4 commits intoelastic:mainfrom
logeekal:fix/flyout_alert_status_update
May 9, 2023
Merged

[Security Solution][Fix] Alert data doesn't update when updating alert status via alert flyout.#156988
logeekal merged 4 commits intoelastic:mainfrom
logeekal:fix/flyout_alert_status_update

Conversation

@logeekal
Copy link
Contributor

@logeekal logeekal commented May 8, 2023 •
edited by kibanamachine
Loading

Summary

This PR handles #156646

Before After
Screen.Recording.2023-05-01.at.5.08.57.PM.mov
Screen.Recording.2023-05-08.at.09.13.11.mov

@logeekal logeekal marked this pull request as ready for review May 8, 2023 17:18
@logeekal logeekal requested review from a team as code owners May 8, 2023 17:18
@logeekal logeekal added Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.8.0 v8.9.0 release_note:skip Skip the PR/issue when compiling release notes labels May 8, 2023
michaelolo24
michaelolo24 approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting in this fix! We can tackle performance in a follow up

@logeekal logeekal enabled auto-merge (squash) May 9, 2023 12:59
@kibana-ci
Copy link

kibana-ci commented May 9, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +224.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@logeekal logeekal merged commit bfad355 into elastic:main May 9, 2023
@logeekal logeekal mentioned this pull request May 9, 2023
Merged
@logeekal
Copy link
Contributor Author

logeekal commented May 9, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

logeekal added a commit to logeekal/kibana that referenced this pull request May 9, 2023
@logeekal
[Security Solution][Fix] Alert data doesn't update when updating aler…
edb941a 
…t status via alert flyout. (elastic#156988)

## Summary

This PR handles elastic#156646

|Before|After|
|---|---|
|<video
src="https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov"
/> | <video
src="https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov"
/> | <video
src="https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov"
/> |

(cherry picked from commit bfad355)
@kibanamachine kibanamachine mentioned this pull request May 9, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 9, 2023
@logeekal
[Security Solution][Fix] Alert data doesn't update when updating aler…
6f686e5 
…t status via alert flyout. (elastic#156988)

## Summary

This PR handles elastic#156646

|Before|After|
|---|---|
|<video
src="https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov"
/> | <video
src="https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov"
/> | <video
src="https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov"
/> |

(cherry picked from commit bfad355)
@kibanamachine
Copy link
Contributor

kibanamachine commented May 9, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

logeekal added a commit that referenced this pull request May 9, 2023
@logeekal
[8.8] [Security Solution][Fix] Alert data doesn't update when updatin…
5a5fb99 
…g alert status via alert flyout. (#156988) (#157179)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution][Fix] Alert data doesn't update when updating
alert status via alert flyout.
(#156988)](#156988)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T14:40:02Z","message":"[Security
Solution][Fix] Alert data doesn't update when updating alert status via
alert flyout. (#156988)\n\n## Summary\r\n\r\nThis PR handles
#156646\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov\"\r\n/>
|","sha":"bfad355dd8424c528e96656b80d09879d9fe8b37","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":156988,"url":"https://github.com/elastic/kibana/pull/156988","mergeCommit":{"message":"[Security
Solution][Fix] Alert data doesn't update when updating alert status via
alert flyout. (#156988)\n\n## Summary\r\n\r\nThis PR handles
#156646\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov\"\r\n/>
|","sha":"bfad355dd8424c528e96656b80d09879d9fe8b37"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156988","number":156988,"mergeCommit":{"message":"[Security
Solution][Fix] Alert data doesn't update when updating alert status via
alert flyout. (#156988)\n\n## Summary\r\n\r\nThis PR handles
#156646\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov\"\r\n/>
|","sha":"bfad355dd8424c528e96656b80d09879d9fe8b37"}}]}] BACKPORT-->
kibanamachine added a commit that referenced this pull request May 9, 2023
@kibanamachine @logeekal
[8.8] [Security Solution][Fix] Alert data doesn't update when updatin…
280ddc4 
…g alert status via alert flyout. (#156988) (#157181)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution][Fix] Alert data doesn't update when updating
alert status via alert flyout.
(#156988)](#156988)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T14:40:02Z","message":"[Security
Solution][Fix] Alert data doesn't update when updating alert status via
alert flyout. (#156988)\n\n## Summary\r\n\r\nThis PR handles
#156646\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov\"\r\n/>
|","sha":"bfad355dd8424c528e96656b80d09879d9fe8b37","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":156988,"url":"https://github.com/elastic/kibana/pull/156988","mergeCommit":{"message":"[Security
Solution][Fix] Alert data doesn't update when updating alert status via
alert flyout. (#156988)\n\n## Summary\r\n\r\nThis PR handles
#156646\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov\"\r\n/>
|","sha":"bfad355dd8424c528e96656b80d09879d9fe8b37"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156988","number":156988,"mergeCommit":{"message":"[Security
Solution][Fix] Alert data doesn't update when updating alert status via
alert flyout. (#156988)\n\n## Summary\r\n\r\nThis PR handles
#156646\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/18648970/235540206-8f6713a7-3619-449d-bd22-9ac8280b8439.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236759487-2e80a908-55dd-4c26-8549-44a317eac4d7.mov\"\r\n/>
|
<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236828096-9f7a1892-8038-4893-9dd6-379544579243.mov\"\r\n/>
|","sha":"bfad355dd8424c528e96656b80d09879d9fe8b37"}}]}] BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.8.0 v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@logeekal @kibana-ci @kibanamachine @michaelolo24