Skip to content

[Security Solution] Actions with conditional logic cannot be added through bulk actions (#156866)#156905

Merged
e40pud merged 1 commit intoelastic:mainfrom
e40pud:security/bugfix/conditional-actions-bulk-edit
May 8, 2023
Merged

[Security Solution] Actions with conditional logic cannot be added through bulk actions (#156866)#156905
e40pud merged 1 commit intoelastic:mainfrom
e40pud:security/bugfix/conditional-actions-bulk-edit

Conversation

@e40pud
Copy link
Contributor

@e40pud e40pud commented May 5, 2023

Summary

Original ticket: #156866

These changes fix the issue with the conditional actions in bulk editing. We did not add action filter attributes to the bulk editing scheme.

More details here #156866 (comment)

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Alerts Security Detection Alerts Area Team backport:prev-minor ci:cloud-deploy Create or update a Cloud deployment labels May 5, 2023
@e40pud e40pud self-assigned this May 5, 2023
@e40pud e40pud requested review from a team as code owners May 5, 2023 18:43
@e40pud e40pud requested a review from jpdjere May 5, 2023 18:43
@kibana-ci
Copy link

kibana-ci commented May 5, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters "after each" hook for "Changed banner should hide on Reset"
  • [job] [logs] Security Solution Tests #1 / Detections : Page Filters Changed banner should hide on Reset

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +335.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing and working as expected. LGTM 👍

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
…rough bulk actions (elastic#156866) (elastic#156905)

## Summary

Original ticket: elastic#156866

These changes fix the issue with the conditional actions in bulk
editing. We did not add action filter attributes to the bulk editing
scheme.

More details here
elastic#156866 (comment)

(cherry picked from commit 9f69d2d)
kibanamachine added a commit that referenced this pull request May 8, 2023
…ded through bulk actions (#156866) (#156905) (#156976)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Actions with conditional logic cannot be added
through bulk actions (#156866)
(#156905)](#156905)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T12:01:18Z","message":"[Security
Solution] Actions with conditional logic cannot be added through bulk
actions (#156866) (#156905)\n\n## Summary\r\n\r\nOriginal ticket:
https://github.com/elastic/kibana/issues/156866\r\n\r\nThese changes fix
the issue with the conditional actions in bulk\r\nediting. We did not
add action filter attributes to the bulk editing\r\nscheme.\r\n\r\nMore
details
here\r\nhttps://github.com//issues/156866#issuecomment-1536469202","sha":"9f69d2dafd2ad7d53525f2f55967b7128644516a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detection
Rules","Team:Detection
Alerts","backport:prev-minor","ci:cloud-deploy","v8.9.0"],"number":156905,"url":"https://github.com/elastic/kibana/pull/156905","mergeCommit":{"message":"[Security
Solution] Actions with conditional logic cannot be added through bulk
actions (#156866) (#156905)\n\n## Summary\r\n\r\nOriginal ticket:
https://github.com/elastic/kibana/issues/156866\r\n\r\nThese changes fix
the issue with the conditional actions in bulk\r\nediting. We did not
add action filter attributes to the bulk editing\r\nscheme.\r\n\r\nMore
details
here\r\nhttps://github.com//issues/156866#issuecomment-1536469202","sha":"9f69d2dafd2ad7d53525f2f55967b7128644516a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156905","number":156905,"mergeCommit":{"message":"[Security
Solution] Actions with conditional logic cannot be added through bulk
actions (#156866) (#156905)\n\n## Summary\r\n\r\nOriginal ticket:
https://github.com/elastic/kibana/issues/156866\r\n\r\nThese changes fix
the issue with the conditional actions in bulk\r\nediting. We did not
add action filter attributes to the bulk editing\r\nscheme.\r\n\r\nMore
details
here\r\nhttps://github.com//issues/156866#issuecomment-1536469202","sha":"9f69d2dafd2ad7d53525f2f55967b7128644516a"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team:Detection Rule Management Security Detection Rule Management Team v8.8.0 v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants