[Security Solution] [Fix] View all open alerts in Detection Response dashboard #156893
Merged
logeekal merged 7 commits intoelastic:mainfrom May 8, 2023
Merged
[Security Solution] [Fix] View all open alerts in Detection Response dashboard #156893logeekal merged 7 commits intoelastic:mainfrom
logeekal merged 7 commits intoelastic:mainfrom
Conversation
logeekal
added
release_note:feature
logeekal
changed the title
x-pack/plugins/security_solution/public/overview/components/detection_response/translations.ts
Outdated
Show resolved
Hide resolved
...n/public/overview/components/detection_response/user_alerts_table/user_alerts_table.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/dashboards/detection_response.cy.ts
Show resolved
Hide resolved
PhilippeOberti
approved these changes
May 5, 2023
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
pulled down and tested, works as expected. Code LGTM except a small comment on username vs user name. I'll let you decide on that!
machadoum
approved these changes
May 8, 2023
Member
machadoum
left a comment
machadoum
left a comment
There was a problem hiding this comment.
CellActions changes look good to me!
Thank you for the fix! 🙇
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @logeekal |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2023
…dashboard (elastic#156893) ## Summary This PR handles : elastic#149096 - Fixes the redirection of `View all open alerts` button - Adds cypress tests for Detection and Response dashboard |Before|After| |---|---| |<video src="https://user-images.githubusercontent.com/108654988/213136589-b7ba4a54-68cb-4723-9b6f-8560b1d7ee55.mp4">|<video src="https://user-images.githubusercontent.com/7485038/236519746-2d5e5e5a-84a6-4762-9ddf-6f0039c5410a.mov">| ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) (cherry picked from commit a513ec6)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 8, 2023
…ponse dashboard (#156893) (#157006) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893)](#156893) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T14:42:25Z","message":"[Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893)\n\n## Summary\r\n\r\nThis PR handles : https://github.com/elastic/kibana/issues/149096\r\n- Fixes the redirection of `View all open alerts` button\r\n- Adds cypress tests for Detection and Response dashboard\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/108654988/213136589-b7ba4a54-68cb-4723-9b6f-8560b1d7ee55.mp4\">|<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236519746-2d5e5e5a-84a6-4762-9ddf-6f0039c5410a.mov\">|\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"a513ec6303741a8f4e79c3a0ece1dbc855189df2","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Team:Threat Hunting:Investigations","Team:Threat Hunting:Explore","v8.8.0","v8.9.0"],"number":156893,"url":"https://github.com/elastic/kibana/pull/156893","mergeCommit":{"message":"[Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893)\n\n## Summary\r\n\r\nThis PR handles : https://github.com/elastic/kibana/issues/149096\r\n- Fixes the redirection of `View all open alerts` button\r\n- Adds cypress tests for Detection and Response dashboard\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/108654988/213136589-b7ba4a54-68cb-4723-9b6f-8560b1d7ee55.mp4\">|<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236519746-2d5e5e5a-84a6-4762-9ddf-6f0039c5410a.mov\">|\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"a513ec6303741a8f4e79c3a0ece1dbc855189df2"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156893","number":156893,"mergeCommit":{"message":"[Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893)\n\n## Summary\r\n\r\nThis PR handles : https://github.com/elastic/kibana/issues/149096\r\n- Fixes the redirection of `View all open alerts` button\r\n- Adds cypress tests for Detection and Response dashboard\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\"https://user-images.githubusercontent.com/108654988/213136589-b7ba4a54-68cb-4723-9b6f-8560b1d7ee55.mp4\">|<video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/236519746-2d5e5e5a-84a6-4762-9ddf-6f0039c5410a.mov\">|\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"a513ec6303741a8f4e79c3a0ece1dbc855189df2"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles : #149096
View all open alertsbuttonAlerts.-.Kibana.-.Google.Chrome.2023-01-18.14-48-02.mp4
Screen.Recording.2023-05-05.at.18.54.46.mov
Checklist
Delete any items that are not applicable to this PR.