Skip to content

Stabilize formatters tests #156835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 4 commits into from
May 8, 2023
Merged

Stabilize formatters tests #156835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cea220
Stabilize formatters tests
stratoula May 5, 2023
b2f13c0
Commit all files
stratoula May 5, 2023
a1e252d
Merge branch 'main' into refactor-field-formatters-tests
stratoula May 5, 2023
2e28e1c
Unskip
stratoula May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/functional/services/field_editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@ export class FieldEditorService extends FtrService {
public async disableValue() {
await this.testSubjects.setEuiSwitch('valueRow > toggle', 'uncheck');
}
public async clearScript() {
const editor = await (
await this.testSubjects.find('valueRow')
).findByClassName('react-monaco-editor-container');
const textarea = await editor.findByClassName('monaco-mouse-cursor-text');
await textarea.click();
const input = await this.find.activeElement();
await input.clearValueWithKeyboard();
}
public async typeScript(script: string) {
const editor = await (
await this.testSubjects.find('valueRow')
Expand Down
29 changes: 11 additions & 18 deletions x-pack/test/functional/apps/lens/group2/field_formatters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const retry = getService('retry');
const fieldEditor = getService('fieldEditor');

// flaky test: https://github.com/elastic/kibana/issues/156153
describe.skip('lens fields formatters tests', () => {
describe('lens fields formatters tests', () => {
before(async () => {
await PageObjects.visualize.navigateToNewVisualization();
await PageObjects.visualize.clickVisType('lens');
await PageObjects.lens.goToTimeRange();
await PageObjects.lens.switchToVisualization('lnsDatatable');
});

afterEach(async () => {
after(async () => {
await PageObjects.lens.clickField('runtimefield');
await PageObjects.lens.removeField('runtimefield');
await fieldEditor.confirmDelete();
Expand Down Expand Up @@ -61,10 +60,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should display static lookup formatter correctly', async () => {
await retry.try(async () => {
await PageObjects.lens.clickAddField();
await fieldEditor.setName('runtimefield');
await fieldEditor.enableValue();
await fieldEditor.typeScript("emit(doc['geo.dest'].value)");
await PageObjects.lens.clickField('runtimefield');
await PageObjects.lens.editField('runtimefield');
await fieldEditor.setFormat(FIELD_FORMAT_IDS.STATIC_LOOKUP);
await fieldEditor.setStaticLookupFormat('CN', 'China');
await fieldEditor.save();
Expand All @@ -77,10 +74,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should display color formatter correctly', async () => {
await retry.try(async () => {
await PageObjects.lens.clickAddField();
await fieldEditor.setName('runtimefield');
await fieldEditor.enableValue();
await fieldEditor.typeScript("emit(doc['geo.dest'].value)");
await PageObjects.lens.clickField('runtimefield');
await PageObjects.lens.editField('runtimefield');
await fieldEditor.setFormat(FIELD_FORMAT_IDS.COLOR);
await fieldEditor.setColorFormat('CN', '#ffffff', '#ff0000');
await fieldEditor.save();
Expand All @@ -95,10 +90,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should display string formatter correctly', async () => {
await retry.try(async () => {
await PageObjects.lens.clickAddField();
await fieldEditor.setName('runtimefield');
await fieldEditor.enableValue();
await fieldEditor.typeScript("emit(doc['geo.dest'].value)");
await PageObjects.lens.clickField('runtimefield');
await PageObjects.lens.editField('runtimefield');
await fieldEditor.setFormat(FIELD_FORMAT_IDS.STRING);
await fieldEditor.setStringFormat('lower');
await fieldEditor.save();
Expand All @@ -111,9 +104,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('should display truncate string formatter correctly', async () => {
await retry.try(async () => {
await PageObjects.lens.clickAddField();
await fieldEditor.setName('runtimefield');
await fieldEditor.enableValue();
await PageObjects.lens.clickField('runtimefield');
await PageObjects.lens.editField('runtimefield');
await fieldEditor.clearScript();
await fieldEditor.typeScript("emit(doc['links.raw'].value)");
await fieldEditor.setFormat(FIELD_FORMAT_IDS.TRUNCATE);
await fieldEditor.setTruncateFormatLength('3');
Expand Down