[8.8] [RAM] Alert search bar only KQL (#155947)#156793
Merged
kibanamachine merged 1 commit intoelastic:8.8from May 5, 2023
Merged
[8.8] [RAM] Alert search bar only KQL (#155947)#156793kibanamachine merged 1 commit intoelastic:8.8from
kibanamachine merged 1 commit intoelastic:8.8from
Conversation
## Summary Adding the props `showQueryInput` is fixing the layout of of the filters. We also wanted to make sure that our alert search bar can only work with KQL because we need to do some kind of validation on the field used in the search bar, therefore it will be easier to just use KueryNode for now. ### Before: <img width="754" alt="Screenshot 2023-04-26 at 1 52 44 PM" src="https://user-images.githubusercontent.com/189600/234698078-612f03be-3331-41ab-a2d9-80f6cd767043.png"> ### After: <img width="749" alt="image" src="https://user-images.githubusercontent.com/189600/234697735-abafc15f-5562-42a0-aeb9-638129d70120.png"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit af7e34a)
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @XavierM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.8:Questions ?
Please refer to the Backport tool documentation