Skip to content

Upgrade xml2js (0.4.22 -> 0.5.0)#156737

Merged
jeramysoucy merged 3 commits intoelastic:mainfrom
jeramysoucy:bump-xml2js
May 17, 2023
Merged

Upgrade xml2js (0.4.22 -> 0.5.0)#156737
jeramysoucy merged 3 commits intoelastic:mainfrom
jeramysoucy:bump-xml2js

Conversation

@jeramysoucy
Copy link
Copy Markdown
Contributor

@jeramysoucy jeramysoucy commented May 4, 2023 •
edited by kibanamachine
Loading

Summary

Updates the xml2js package dependency from v0.4.22 to v0.5.0.

@jeramysoucy jeramysoucy added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release v8.9.0 labels May 4, 2023
@jeramysoucy jeramysoucy marked this pull request as ready for review May 4, 2023 20:17
@jeramysoucy jeramysoucy changed the title Upgrade xml2js 0.4.22 -> 0.5.0 Upgrade xml2js (0.4.22 -> 0.5.0) May 4, 2023
@jeramysoucy jeramysoucy changed the title Upgrade xml2js (0.4.22 -> 0.5.0) Upgrade xml2js (0.4.22 -> 0.5.0) May 4, 2023
@jeramysoucy jeramysoucy mentioned this pull request May 4, 2023
Closed
9 tasks
@jeramysoucy jeramysoucy requested a review from a team May 5, 2023 13:43
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 5, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #60 / spaces api without security _update_objects_spaces targeting the default space "before all" hook for "should return 200 {objects: [default_only,space_1_only,space_2_only,default_and_space_1,default_and_space_2,space_1_and_space_2,each_space,all_spaces,does_not_exist], spacesToAdd: [some-space-id], spacesToRemove: [default]}"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 995 948 -47

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB -23.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kc13greiner
kc13greiner approved these changes May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeramysoucy jeramysoucy merged commit b140e08 into elastic:main May 17, 2023
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 17, 2023

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- upgrade webdriver to 4.9.1 (#157137)
- [Reporting/Screenshotting] upgrade Puppeteer dependency to v20.1.0 (#156766)
❌ 8.8 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 156737

Questions ?

Please refer to the Backport tool documentation

@jeramysoucy jeramysoucy mentioned this pull request May 18, 2023
Merged
jeramysoucy added a commit to jeramysoucy/kibana that referenced this pull request May 18, 2023
@jeramysoucy
Upgrade xml2js (0.4.22 -> 0.5.0) (elastic#156737)
a0047e3 
## Summary
Updates the xml2js package dependency from v0.4.22 to v0.5.0.

(cherry picked from commit b140e08)

# Conflicts:
#	package.json
jeramysoucy added a commit to jeramysoucy/kibana that referenced this pull request May 18, 2023
@jeramysoucy
Upgrade xml2js (0.4.22 -> 0.5.0) (elastic#156737)
6369789 
## Summary
Updates the xml2js package dependency from v0.4.22 to v0.5.0.

(cherry picked from commit b140e08)

# Conflicts:
#	package.json
#	yarn.lock
@jeramysoucy jeramysoucy mentioned this pull request May 18, 2023
Merged
@jeramysoucy
Copy link
Copy Markdown
Contributor Author

jeramysoucy commented May 18, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.8
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jeramysoucy added a commit that referenced this pull request May 18, 2023
@jeramysoucy
[8.8] Upgrade xml2js (0.4.22 -> 0.5.0) (#156737) (#158082)
eccc8a9 
# Backport

This will backport the following commits from `main` to `8.8`:
- [Upgrade `xml2js` (0.4.22 -> 0.5.0)
(#156737)](#156737)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T20:05:38Z","message":"Upgrade
`xml2js` (0.4.22 -> 0.5.0) (#156737)\n\n## Summary\r\nUpdates the xml2js
package dependency from v0.4.22 to
v0.5.0.","sha":"b140e089a24e3e30f338362adab5c71a8a9f9efb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.9.0"],"number":156737,"url":"https://github.com/elastic/kibana/pull/156737","mergeCommit":{"message":"Upgrade
`xml2js` (0.4.22 -> 0.5.0) (#156737)\n\n## Summary\r\nUpdates the xml2js
package dependency from v0.4.22 to
v0.5.0.","sha":"b140e089a24e3e30f338362adab5c71a8a9f9efb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156737","number":156737,"mergeCommit":{"message":"Upgrade
`xml2js` (0.4.22 -> 0.5.0) (#156737)\n\n## Summary\r\nUpdates the xml2js
package dependency from v0.4.22 to
v0.5.0.","sha":"b140e089a24e3e30f338362adab5c71a8a9f9efb"}}]}]
BACKPORT-->
jeramysoucy added a commit that referenced this pull request May 18, 2023
@jeramysoucy @kibanamachine
[7.17] Upgrade xml2js (0.4.22 -> 0.5.0) (#156737) (#158083)
213dbc3 
# Backport

This will backport the following commits from `main` to `7.17`:
- [Upgrade `xml2js` (0.4.22 -> 0.5.0)
(#156737)](#156737)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T20:05:38Z","message":"Upgrade
`xml2js` (0.4.22 -> 0.5.0) (#156737)\n\n## Summary\r\nUpdates the xml2js
package dependency from v0.4.22 to
v0.5.0.","sha":"b140e089a24e3e30f338362adab5c71a8a9f9efb","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.9.0"],"number":156737,"url":"https://github.com/elastic/kibana/pull/156737","mergeCommit":{"message":"Upgrade
`xml2js` (0.4.22 -> 0.5.0) (#156737)\n\n## Summary\r\nUpdates the xml2js
package dependency from v0.4.22 to
v0.5.0.","sha":"b140e089a24e3e30f338362adab5c71a8a9f9efb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156737","number":156737,"mergeCommit":{"message":"Upgrade
`xml2js` (0.4.22 -> 0.5.0) (#156737)\n\n## Summary\r\nUpdates the xml2js
package dependency from v0.4.22 to
v0.5.0.","sha":"b140e089a24e3e30f338362adab5c71a8a9f9efb"}}]}]
BACKPORT-->

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kc13greiner kc13greiner kc13greiner approved these changes

Assignees

No one assigned

Labels

backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes v7.17.11 v8.8.0 v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeramysoucy @kibana-ci @kibanamachine @kc13greiner