Skip to content

[Security Solution][Endpoint] Fix hover color for processes response action output data rows#156734

Merged
paul-tavares merged 1 commit intoelastic:mainfrom
paul-tavares:task/olm-154594-fix-selection-in-console-with-dark-theme
May 8, 2023
Merged

[Security Solution][Endpoint] Fix hover color for processes response action output data rows#156734
paul-tavares merged 1 commit intoelastic:mainfrom
paul-tavares:task/olm-154594-fix-selection-in-console-with-dark-theme

Conversation

@paul-tavares
Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares commented May 4, 2023 •
edited by kibanamachine
Loading

Summary

  • Fixes the color used to highlight a row from the output of the processes response action so that selected content (via mouse) is still legible when the kibana dark theme is used.

Fixes: #154594

image

Click here to view selection prior to this change

Your content here

@paul-tavares paul-tavares added release_note:fix Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 labels May 4, 2023
@paul-tavares paul-tavares self-assigned this May 4, 2023
@paul-tavares paul-tavares requested a review from a team as a code owner May 4, 2023 19:50
@paul-tavares paul-tavares requested review from pzl and tomsonpl May 4, 2023 19:50
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 4, 2023

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares paul-tavares mentioned this pull request May 4, 2023
Closed
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 4, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +8.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@dasansol92
Copy link
Copy Markdown
Contributor

dasansol92 commented May 5, 2023

@paul-tavares Should we add the 8.9.0 version label?

@paul-tavares
Copy link
Copy Markdown
Contributor Author

paul-tavares commented May 5, 2023

@dasansol92 - good catch. I added the label for 8.9. Thanks for the 👍

@paul-tavares paul-tavares merged commit 3b789e3 into elastic:main May 8, 2023
@paul-tavares paul-tavares deleted the task/olm-154594-fix-selection-in-console-with-dark-theme branch May 8, 2023 13:13
@kibanamachine kibanamachine mentioned this pull request May 8, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
@paul-tavares
[Security Solution][Endpoint] Fix hover color for processes respons…
f521143 
…e action output data rows (elastic#156734)

## Summary

- Fixes the color used to highlight a row from the output of the
`processes` response action so that selected content (via mouse) is
still legible when the kibana dark theme is used.

Fixes: elastic#154594
(cherry picked from commit 3b789e3)
@kibanamachine kibanamachine mentioned this pull request May 8, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
@paul-tavares
[Security Solution][Endpoint] Fix hover color for processes respons…
3ae8f93 
…e action output data rows (elastic#156734)

## Summary

- Fixes the color used to highlight a row from the output of the
`processes` response action so that selected content (via mouse) is
still legible when the kibana dark theme is used.

Fixes: elastic#154594
(cherry picked from commit 3b789e3)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 8, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.7
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2023
@kibanamachine @paul-tavares
[8.8] [Security Solution][Endpoint] Fix hover color for processes r…
d287069 
…esponse action output data rows (#156734) (#156994)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution][Endpoint] Fix hover color for `processes`
response action output data rows
(#156734)](#156734)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paul
Tavares","email":"56442535+paul-tavares@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-08T13:13:20Z","message":"[Security
Solution][Endpoint] Fix hover color for `processes` response action
output data rows (#156734)\n\n## Summary\r\n\r\n- Fixes the color used
to highlight a row from the output of the\r\n`processes` response action
so that selected content (via mouse) is\r\nstill legible when the kibana
dark theme is used.\r\n\r\nFixes:
#154594","sha":"3b789e31cd0f388f4dfdeb834ecdfdbbcca2a79f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Defend
Workflows","v8.8.0","v8.7.2","v8.9.0"],"number":156734,"url":"https://github.com/elastic/kibana/pull/156734","mergeCommit":{"message":"[Security
Solution][Endpoint] Fix hover color for `processes` response action
output data rows (#156734)\n\n## Summary\r\n\r\n- Fixes the color used
to highlight a row from the output of the\r\n`processes` response action
so that selected content (via mouse) is\r\nstill legible when the kibana
dark theme is used.\r\n\r\nFixes:
#154594","sha":"3b789e31cd0f388f4dfdeb834ecdfdbbcca2a79f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156734","number":156734,"mergeCommit":{"message":"[Security
Solution][Endpoint] Fix hover color for `processes` response action
output data rows (#156734)\n\n## Summary\r\n\r\n- Fixes the color used
to highlight a row from the output of the\r\n`processes` response action
so that selected content (via mouse) is\r\nstill legible when the kibana
dark theme is used.\r\n\r\nFixes:
#154594","sha":"3b789e31cd0f388f4dfdeb834ecdfdbbcca2a79f"}}]}]
BACKPORT-->

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request May 8, 2023
@kibanamachine @paul-tavares
[8.7] [Security Solution][Endpoint] Fix hover color for processes r…
28f77fb 
…esponse action output data rows (#156734) (#156992)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution][Endpoint] Fix hover color for `processes`
response action output data rows
(#156734)](#156734)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paul
Tavares","email":"56442535+paul-tavares@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-08T13:13:20Z","message":"[Security
Solution][Endpoint] Fix hover color for `processes` response action
output data rows (#156734)\n\n## Summary\r\n\r\n- Fixes the color used
to highlight a row from the output of the\r\n`processes` response action
so that selected content (via mouse) is\r\nstill legible when the kibana
dark theme is used.\r\n\r\nFixes:
#154594","sha":"3b789e31cd0f388f4dfdeb834ecdfdbbcca2a79f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Defend
Workflows","v8.8.0","v8.7.2","v8.9.0"],"number":156734,"url":"https://github.com/elastic/kibana/pull/156734","mergeCommit":{"message":"[Security
Solution][Endpoint] Fix hover color for `processes` response action
output data rows (#156734)\n\n## Summary\r\n\r\n- Fixes the color used
to highlight a row from the output of the\r\n`processes` response action
so that selected content (via mouse) is\r\nstill legible when the kibana
dark theme is used.\r\n\r\nFixes:
#154594","sha":"3b789e31cd0f388f4dfdeb834ecdfdbbcca2a79f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156734","number":156734,"mergeCommit":{"message":"[Security
Solution][Endpoint] Fix hover color for `processes` response action
output data rows (#156734)\n\n## Summary\r\n\r\n- Fixes the color used
to highlight a row from the output of the\r\n`processes` response action
so that selected content (via mouse) is\r\nstill legible when the kibana
dark theme is used.\r\n\r\nFixes:
#154594","sha":"3b789e31cd0f388f4dfdeb834ecdfdbbcca2a79f"}}]}]
BACKPORT-->

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dasansol92 dasansol92 dasansol92 approved these changes

@pzl pzl Awaiting requested review from pzl pzl was automatically assigned from elastic/security-defend-workflows

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl was automatically assigned from elastic/security-defend-workflows

+1 more reviewer

@kevinlog kevinlog kevinlog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paul-tavares paul-tavares

Labels

release_note:fix Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.7.2 v8.8.0 v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Security Solution] Response Console Hard to Read in Dark Mode (Get Processes)

6 participants

@paul-tavares @elasticmachine @kibana-ci @dasansol92 @kibanamachine @kevinlog