Skip to content

[8.8] [Security Solution] fixes Data Quality dashboard errors when a basePath is configured (#156233)#156730

Merged
kibanamachine merged 1 commit intoelastic:8.8from
kibanamachine:backport/8.8/pr-156233
May 4, 2023
Merged

[8.8] [Security Solution] fixes Data Quality dashboard errors when a basePath is configured (#156233)#156730
kibanamachine merged 1 commit intoelastic:8.8from
kibanamachine:backport/8.8/pr-156233

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

…ath` is configured (elastic#156233)

## [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured

This PR implements a fix for an [issue](elastic#156231) where the Data Quality dashboard displays errors when  a `basePath` is configured, preventing indices from being checked.

### Desk testing

- Verify the fix per the reporduction steps in <elastic#156231>
- Also verify the page still behaves correctly when Kibana is started with no base path, via:

```
yarn start --no-base-path
```

### Before / after screenshots

**Before:**

![before](https://user-images.githubusercontent.com/4459398/235273609-952fd7e4-0a22-4344-b1e4-48411c6d0e33.png)

_Above: Before the fix, errors occur when a `basePath` is configured_

**After:**

![after](https://user-images.githubusercontent.com/4459398/235276257-c62feb05-699a-418c-8da2-b90b6683e5b4.png)

_Above: After the fix, errors do NOT occur_

(cherry picked from commit 3389a2b)
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3860 3861 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB +423.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @andrew-goldstein

@kibanamachine kibanamachine merged commit a5f358c into elastic:8.8 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants