Skip to content

[Dashboard Navigation] Create and register navigation embeddable plugin#156627

Merged
nickpeihl merged 8 commits intoelastic:navigation-embeddablefrom
nickpeihl:kibana-navembeddable-plugin
May 4, 2023
Merged

[Dashboard Navigation] Create and register navigation embeddable plugin#156627
nickpeihl merged 8 commits intoelastic:navigation-embeddablefrom
nickpeihl:kibana-navembeddable-plugin

Conversation

@nickpeihl
Copy link
Contributor

@nickpeihl nickpeihl commented May 3, 2023

Summary

Stubs out the Navigation embeddable plugin. All initial work on this feature is being merged into the navigation-embeddable feature branch.

Fixes #154355

This placeholder embeddable can be added to a dashboard by selecting "Navigation" from the "Select type" dropdown.

localhost_5601_ydx_app_dashboards

@nickpeihl nickpeihl changed the title Create and register navigation embeddable plugin [Dashboard Navigation] Create and register navigation embeddable plugin May 3, 2023
@nickpeihl nickpeihl requested a review from Heenawter May 3, 2023 22:29
@nickpeihl nickpeihl added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// label May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl requested a review from a team as a code owner May 4, 2023 14:01
Copy link
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limits.yml

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
navigationEmbeddable - 7 +7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
navigationEmbeddable - 18 +18

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
navigationEmbeddable - 2.8KB +2.8KB
Unknown metric groups

API count

id before after diff
navigationEmbeddable - 18 +18

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + quick local test. LGTM as the first step - so excited to get this project started 💃

@nickpeihl nickpeihl merged commit 7739884 into elastic:navigation-embeddable May 4, 2023
Heenawter pushed a commit to Heenawter/kibana that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants