Fix preview chart in APM rules#156625
Closed
benakansara wants to merge 9 commits intoelastic:mainfrom
Closed
Conversation
benakansara
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
benakansara
added a commit
that referenced
this pull request
May 8, 2023
Hides preview charts in the following APM rules until #156625 (WIP) gets merged. - APM Latency threshold - APM Failed transaction rate - APM Error count threshold
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2023
Hides preview charts in the following APM rules until elastic#156625 (WIP) gets merged. - APM Latency threshold - APM Failed transaction rate - APM Error count threshold (cherry picked from commit d10c48b)
kibanamachine
added a commit
that referenced
this pull request
May 8, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [Hide preview charts in APM rules (#156966)](#156966) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-08T11:12:08Z","message":"Hide preview charts in APM rules (#156966)\n\nHides preview charts in the following APM rules until\r\nhttps://github.com//pull/156625 (WIP) gets merged.\r\n\r\n- APM Latency threshold\r\n- APM Failed transaction rate\r\n- APM Error count threshold","sha":"d10c48b983404025c6b0009c899ccc59c655bc6d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","Team: Actionable Observability","v8.8.0","v8.9.0"],"number":156966,"url":"https://github.com/elastic/kibana/pull/156966","mergeCommit":{"message":"Hide preview charts in APM rules (#156966)\n\nHides preview charts in the following APM rules until\r\nhttps://github.com//pull/156625 (WIP) gets merged.\r\n\r\n- APM Latency threshold\r\n- APM Failed transaction rate\r\n- APM Error count threshold","sha":"d10c48b983404025c6b0009c899ccc59c655bc6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156966","number":156966,"mergeCommit":{"message":"Hide preview charts in APM rules (#156966)\n\nHides preview charts in the following APM rules until\r\nhttps://github.com//pull/156625 (WIP) gets merged.\r\n\r\n- APM Latency threshold\r\n- APM Failed transaction rate\r\n- APM Error count threshold","sha":"d10c48b983404025c6b0009c899ccc59c655bc6d"}}]}] BACKPORT--> Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @benakansara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following for APM Latency threshold rule: