[Enterprise Search] Add telemetry to ELSER deployment buttons + error#156545
Merged
demjened merged 5 commits intoelastic:mainfrom May 4, 2023
Merged
[Enterprise Search] Add telemetry to ELSER deployment buttons + error#156545demjened merged 5 commits intoelastic:mainfrom
demjened merged 5 commits intoelastic:mainfrom
Conversation
demjened
added
Team:EnterpriseSearch
v8.8.0
v8.9.0
release_note:skip
demjened
commented
May 3, 2023
|
|
||
| export const TextExpansionCallOut: React.FC<TextExpansionCallOutProps> = (props) => { | ||
| const { dismiss, isDismissable, show } = useTextExpansionCallOutData(props); | ||
| const { ingestionMethod } = useValues(IndexViewLogic); |
Contributor
Author
There was a problem hiding this comment.
Method of importing ingestionMethod copied from here.
demjened
commented
May 3, 2023
|
|
||
| return ( | ||
| <> | ||
| <SendEnterpriseSearchTelemetry action="error" metric="textExpansionModel-error" /> |
Contributor
Author
There was a problem hiding this comment.
- Per convo with @TattdCodeMonkey I think this is the correct way to send metrics when an error pops up, but let me know if it isn't.
- Not sure about the metric name, the only references I found use short and generic metric names.
…-ref HEAD~1..HEAD --fix'
…d/kibana into demjened/elser-telemetry
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
TattdCodeMonkey
approved these changes
May 4, 2023
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 4, 2023
…elastic#156545) ## Summary This PR adds telemetry to ELSER deployment actions (download, start deployment) and errors. The ELSER 1-click workflow was tested manually to ensure there's no regression. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0742a0c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 4, 2023
… error (#156545) (#156751) # Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)](#156545) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Adam Demjen","email":"demjened@gmail.com"},"sourceCommit":{"committedDate":"2023-05-04T20:21:51Z","message":"[Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)\n\n## Summary\r\n\r\nThis PR adds telemetry to ELSER deployment actions (download, start\r\ndeployment) and errors.\r\n\r\nThe ELSER 1-click workflow was tested manually to ensure there's no\r\nregression.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0742a0c4c430b6425a2afa1f3959bcfc0cae474c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156545,"url":"https://github.com/elastic/kibana/pull/156545","mergeCommit":{"message":"[Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)\n\n## Summary\r\n\r\nThis PR adds telemetry to ELSER deployment actions (download, start\r\ndeployment) and errors.\r\n\r\nThe ELSER 1-click workflow was tested manually to ensure there's no\r\nregression.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0742a0c4c430b6425a2afa1f3959bcfc0cae474c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156545","number":156545,"mergeCommit":{"message":"[Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)\n\n## Summary\r\n\r\nThis PR adds telemetry to ELSER deployment actions (download, start\r\ndeployment) and errors.\r\n\r\nThe ELSER 1-click workflow was tested manually to ensure there's no\r\nregression.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"0742a0c4c430b6425a2afa1f3959bcfc0cae474c"}}]}] BACKPORT--> Co-authored-by: Adam Demjen <demjened@gmail.com>
jloleysens
added a commit
that referenced
this pull request
May 5, 2023
* main: (153 commits)
[Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
[Synthetics] refresh data on visualization scrubbing (#156777)
[RAM] Docs for slack improvements (#153885)
[RAM] Alert search bar only KQL (#155947)
[ML] Functional tests - stabilize export job tests (#156586)
[Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
[ML] Rename `curated` model type to `elastic` (#156684)
[Discover] Enable sharing for text based languages (#156652)
[api-docs] 2023-05-05 Daily api_docs build (#156781)
Upgrade EUI to v77.2.2 (#155208)
[RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
[DOCS] Case file attachments (#156459)
[D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
[Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
[Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
[Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
[Logs onboarding] StepsFooter outside of main panel (#156686)
[Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
[Enterprise Search][Behavioral Analytics] Update formulas (#156704)
Add API Events to Endpoint Security Advanced Policy (#156718)
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds telemetry to ELSER deployment actions (download, start deployment) and errors.
The ELSER 1-click workflow was tested manually to ensure there's no regression.