Skip to content

Comments

[QA] Fixup flaky test#156373

Merged
wayneseymour merged 2 commits intoelastic:mainfrom
wayneseymour:scroll-count-failure
May 8, 2023
Merged

[QA] Fixup flaky test#156373
wayneseymour merged 2 commits intoelastic:mainfrom
wayneseymour:scroll-count-failure

Conversation

@wayneseymour
Copy link
Contributor

@wayneseymour wayneseymour commented May 2, 2023

Summary

Resolves #136856

@wayneseymour wayneseymour added Team:QA Platform QA t// release_note:skip Skip the PR/issue when compiling release notes labels May 2, 2023
@wayneseymour wayneseymour self-assigned this May 2, 2023
@wayneseymour
Copy link
Contributor Author

@wayneseymour
Copy link
Contributor Author

@wayneseymour
Copy link
Contributor Author

@wayneseymour
Copy link
Contributor Author

Resolves elastic#136856

Add async keyword where it should have been.
Split archive into kbn and es archives...instigated by
Pierre's comment: elastic#136856 (comment)
Note: Had to use both as one archive is "hidden".
Unload via Pierre's "new" clean method.
@wayneseymour wayneseymour force-pushed the scroll-count-failure branch from 4662d1d to a322cdc Compare May 3, 2023 10:22
@wayneseymour wayneseymour requested review from a team and Bamieh May 3, 2023 10:23
@wayneseymour wayneseymour marked this pull request as ready for review May 3, 2023 10:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@wayneseymour
Copy link
Contributor Author

one more flaky test runner run: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2214

@wayneseymour wayneseymour requested a review from a team May 4, 2023 10:18
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour requested review from a team and removed request for a team May 5, 2023 13:16
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour wayneseymour merged commit d1feb43 into elastic:main May 8, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This PR does not require backporting labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// v8.9.0

Projects

None yet

5 participants