Skip to content

[Synthetics] Make error popover disappear onMouseLeave of metric item card #155800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahzad31 merged 1 commit into from
Apr 26, 2023
Merged

[Synthetics] Make error popover disappear onMouseLeave of metric item card #155800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...thetics/public/apps/synthetics/components/monitors_page/overview/overview/metric_item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { DARK_THEME } from '@elastic/charts';
import { useTheme } from '@kbn/observability-plugin/public';
import { useDispatch, useSelector } from 'react-redux';
import moment from 'moment';
import { toggleErrorPopoverOpen } from '../../../../state';
import { selectErrorPopoverState, toggleErrorPopoverOpen } from '../../../../state';
import { useLocationName, useStatusByLocationOverview } from '../../../../hooks';
import { formatDuration } from '../../../../utils/formatting';
import { MonitorOverviewItem } from '../../../../../../../common/runtime_types';
Expand Down Expand Up @@ -63,6 +63,7 @@ export const MetricItem = ({
}) => {
const [isMouseOver, setIsMouseOver] = useState(false);
const [isPopoverOpen, setIsPopoverOpen] = useState(false);
const isErrorPopoverOpen = useSelector(selectErrorPopoverState);
const locationName =
useLocationName({ locationId: monitor.location?.id })?.label || monitor.location?.id;
const { status, timestamp, ping, configIdByLocation } = useStatusByLocationOverview(
Expand All @@ -86,6 +87,9 @@ export const MetricItem = ({
}
}}
onMouseLeave={() => {
if (isErrorPopoverOpen) {
dispatch(toggleErrorPopoverOpen(null));
}
if (isMouseOver) {
setIsMouseOver(false);
}
Expand Down
3 changes: 1 addition & 2 deletions ...cs/public/apps/synthetics/components/monitors_page/overview/overview/metric_item_icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ export const MetricItemIcon = ({
onMouseLeave={() => {
if (isPopoverOpen) {
return;
}
if (timer.current) {
} else if (timer.current) {
clearTimeout(timer.current);
}
}}
Expand Down